linux-kernel - Re: [PATCH 10/17] media: platform: sti: c8sectpfe: c8sectpfe-dvb: convert to use i2c_new_client

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e4fd1be9-9406-7701-9864-56981d486f6f@st.com>
Date:   Thu, 7 Nov 2019 09:59:17 +0000
From:   Patrice CHOTARD <patrice.chotard@...com>
To:     Wolfram Sang <wsa+renesas@...g-engineering.com>,
        "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>
CC:     "linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
        "Mauro Carvalho Chehab" <mchehab@...nel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 10/17] media: platform: sti: c8sectpfe: c8sectpfe-dvb:
 convert to use i2c_new_client_device()

Hi

On 11/6/19 10:21 PM, Wolfram Sang wrote:
> Use the newer API returning an ERRPTR and use the new helper to bail
> out.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@...g-engineering.com>
> ---
>  drivers/media/platform/sti/c8sectpfe/c8sectpfe-dvb.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-dvb.c b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-dvb.c
> index a79250a7f812..103872266565 100644
> --- a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-dvb.c
> +++ b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-dvb.c
> @@ -170,8 +170,8 @@ int c8sectpfe_frontend_attach(struct dvb_frontend **fe,
>  
>  		/* attach tuner */
>  		request_module("tda18212");
> -		client = i2c_new_device(tsin->i2c_adapter, &tda18212_info);
> -		if (!client || !client->dev.driver) {
> +		client = i2c_new_client_device(tsin->i2c_adapter, &tda18212_info);
> +		if (!i2c_client_has_driver(client)) {
>  			dvb_frontend_detach(*fe);
>  			return -ENODEV;
>  		}

Reviewed-by: Patrice Chotard <patrice.chotard@...com>


Thanks