linux-kernel - Re: [PATCH 2/2] rtc: bd70528: Fix hour register mask

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0accbfe75df7b0b72f6880474d9013aad89daae6.camel@fi.rohmeurope.com>
Date:   Thu, 7 Nov 2019 11:46:19 +0000
From:   "Vaittinen, Matti" <Matti.Vaittinen@...rohmeurope.com>
To:     "lee.jones@...aro.org" <lee.jones@...aro.org>,
        "alexandre.belloni@...tlin.com" <alexandre.belloni@...tlin.com>
CC:     "mazziesaccount@...il.com" <mazziesaccount@...il.com>,
        "a.zummo@...ertech.it" <a.zummo@...ertech.it>,
        "linux-rtc@...r.kernel.org" <linux-rtc@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] rtc: bd70528: Fix hour register mask

On Thu, 2019-11-07 at 10:59 +0000, Lee Jones wrote:
> On Tue, 05 Nov 2019, Alexandre Belloni wrote:
> 
> > On 23/10/2019 14:47:51+0300, Matti Vaittinen wrote:
> > > When RTC is used in 24H mode (and it is by this driver) the
> > > maximum
> > > hour value is 24 in BCD. This occupies bits [5:0] - which means
> > > correct mask for HOUR register is 0x3f not 0x1f. Fix the mask
> > > 
> > > Fixes: 32a4a4ebf768 ("rtc: bd70528: Initial support for ROHM
> > > bd70528 RTC")
> > > Signed-off-by: Matti Vaittinen <matti.vaittinen@...rohmeurope.com
> > > >
> > > ---
> > >  include/linux/mfd/rohm-bd70528.h | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > Applied, thanks.
> 
> You have been duped. This is clearly not an RTC patch.

Sorry. My bad. I used the rtc: prefix as this clearly is RTC fix -
although the header may be MFD territory. I should have known that
maintaining is done per file basis. I try to be more careful in the
future.

Br,
	Matti Vaittinen