linux-kernel - Re: [PATCH] staging: gasket: gasket_ioctl: Remove unnecessary line-breaks in funtion signature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 7 Nov 2019 16:09:16 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Joe Perches <joe@...ches.com>
Cc:     Valery Ivanov <ivalery111@...il.com>, rspringer@...gle.com,
        toddpoynor@...gle.com, benchan@...omium.org,
        Simon Que <sque@...omium.org>,
        John Joseph <jnjoseph@...gle.com>, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: gasket: gasket_ioctl: Remove unnecessary
 line-breaks in funtion signature

On Wed, Nov 06, 2019 at 11:12:09AM -0800, Joe Perches wrote:
> On Wed, 2019-11-06 at 18:08 +0000, Valery Ivanov wrote:
> > 	This patch fix the function signature for trace_gasket_ioctl_page_table_data
> > 	to avoid the checkpatch.pl warning:
> > 
> > 		CHECK: Lines should not end with a '('
> > 
> > Signed-off-by: Valery Ivanov <ivalery111@...il.com>
> 
> All of this stuff is no-op and could just as easily be removed
> completely as GASKET_KERNEL_TRACE_SUPPORT is not #defined anywhere.
> 
> Is the actual trace #include file supposed to be available somewhere?
> 
> #ifdef GASKET_KERNEL_TRACE_SUPPORT
> #define CREATE_TRACE_POINTS
> #include <trace/events/gasket_ioctl.h>
> #else
> #define trace_gasket_ioctl_entry(x, ...)
> #define trace_gasket_ioctl_exit(x)
> #define trace_gasket_ioctl_integer_data(x)
> #define trace_gasket_ioctl_eventfd_data(x, ...)
> #define trace_gasket_ioctl_page_table_data(x, ...)
> #define trace_gasket_ioctl_config_coherent_allocator(x, ...)
> #endif
> 
> trace file not found...

I'm thinking the whole gasket driver should be deleted as there has not
been any effort done to fix it up and get it out of staging.  I'll give
it until 5.5 before I drop it...

thanks,

greg k-h