linux-kernel - Re: [PATCH V2 1/4] ARM: dts: imx6sll: Update usdhc fallback compatible to support HS400 mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 7 Nov 2019 12:40:24 -0300
From:   Fabio Estevam <festevam@...il.com>
To:     Anson Huang <Anson.Huang@....com>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Sascha Hauer <kernel@...gutronix.de>,
        Andrey Smirnov <andrew.smirnov@...il.com>,
        Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
        Marcel Ziswiler <marcel.ziswiler@...adex.com>,
        Sébastien Szymanski 
        <sebastien.szymanski@...adeus.com>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@...ts.infradead.org>,
        NXP Linux Team <Linux-imx@....com>
Subject: Re: [PATCH V2 1/4] ARM: dts: imx6sll: Update usdhc fallback
 compatible to support HS400 mode

Hi Anson,

On Wed, Nov 6, 2019 at 11:08 PM Anson Huang <Anson.Huang@....com> wrote:
>
> The latest i.MX6SLL EVK board supports HS400 mode, update usdhc's

Since this is a dtsi patch, it is better not to mention a specific
board here in the commit log.

It would be better to say that unlike i.MX6SL, the i.MX6SLL SoC can
support HS400 mode, hence fsl,imx7d-usdhc should be used as compatible
string.

Regards,

Fabio Estevam
> fallback compatible to support HS400 mode by default.
>
> Signed-off-by: Anson Huang <Anson.Huang@....com>
> ---
> No changes.
> ---
>  arch/arm/boot/dts/imx6sll.dtsi | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx6sll.dtsi b/arch/arm/boot/dts/imx6sll.dtsi
> index 85aa8bb..1c8101f 100644
> --- a/arch/arm/boot/dts/imx6sll.dtsi
> +++ b/arch/arm/boot/dts/imx6sll.dtsi
> @@ -698,7 +698,7 @@
>                         };
>
>                         usdhc1: mmc@...0000 {
> -                               compatible = "fsl,imx6sll-usdhc", "fsl,imx6sx-usdhc";
> +                               compatible = "fsl,imx6sll-usdhc", "fsl,imx7d-usdhc";
>                                 reg = <0x02190000 0x4000>;
>                                 interrupts = <GIC_SPI 22 IRQ_TYPE_LEVEL_HIGH>;
>                                 clocks = <&clks IMX6SLL_CLK_USDHC1>,
> @@ -712,7 +712,7 @@
>                         };
>
>                         usdhc2: mmc@...4000 {
> -                               compatible = "fsl,imx6sll-usdhc", "fsl,imx6sx-usdhc";
> +                               compatible = "fsl,imx6sll-usdhc", "fsl,imx7d-usdhc";
>                                 reg = <0x02194000 0x4000>;
>                                 interrupts = <GIC_SPI 23 IRQ_TYPE_LEVEL_HIGH>;
>                                 clocks = <&clks IMX6SLL_CLK_USDHC2>,
> @@ -726,7 +726,7 @@
>                         };
>
>                         usdhc3: mmc@...8000 {
> -                               compatible = "fsl,imx6sll-usdhc", "fsl,imx6sx-usdhc";
> +                               compatible = "fsl,imx6sll-usdhc", "fsl,imx7d-usdhc";
>                                 reg = <0x02198000 0x4000>;
>                                 interrupts = <GIC_SPI 24 IRQ_TYPE_LEVEL_HIGH>;
>                                 clocks = <&clks IMX6SLL_CLK_USDHC3>,
> --
> 2.7.4
>