linux-kernel - Re: [PATCH] drivers/clk: convert VL struct to struct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20191108133414.72981353@heffalump.sk2.org>
Date:   Fri, 8 Nov 2019 13:34:14 +0100
From:   Stephen Kitt <steve@....org>
To:     Stephen Boyd <sboyd@...nel.org>
Cc:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Michael Turquette <mturquette@...libre.com>,
        Nicolas Ferre <nicolas.ferre@...rochip.com>,
        Paul Burton <paul.burton@...s.com>,
        Paul Cercueil <paul@...pouillou.net>,
        linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers/clk: convert VL struct to struct_size

On Thu, 07 Nov 2019 14:50:01 -0800, Stephen Boyd <sboyd@...nel.org> wrote:
> Quoting Gustavo A. R. Silva (2019-10-02 12:20:28)
> > On 9/27/19 13:51, Stephen Kitt wrote:  
> > > There are a few manually-calculated variable-length struct allocations
> > > left, this converts them to use struct_size.
> > 
> > How did you find this?
> > 
> > Please, mention the tool you used to find this in the commit log. With
> > that you can add my
> > 
> > Acked-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
> 
> Any answer? I'm tempted to just apply the patch anyway.

Sorry, I hadn’t seen Gustavo’s email!

I didn’t use anything particularly fancy to find these, my history says

	git grep -A1 'kzalloc.*sizeof[^_].*+'

and manual review. I noticed that clk/ had a number of hits, but also commits
to switch to struct_size so I reckoned it was worth pursuing the exercise
there.

Is it worth adding that to the commit message?

Regards,

Stephen

Content of type "application/pgp-signature" skipped