linux-kernel - Re: [PATCH] checkpatch: remove "ipc" from list of expected toplevel directories

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1573230479.5838.7.camel@suse.cz>
Date:   Fri, 08 Nov 2019 17:27:59 +0100
From:   Giovanni Gherdovich <ggherdovich@...e.cz>
To:     Joe Perches <joe@...ches.com>, Andy Whitcroft <apw@...onical.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] checkpatch: remove "ipc" from list of expected toplevel
 directories

On Fri, 2019-11-08 at 17:04 +0100, Giovanni Gherdovich wrote:
> checkpatch.pl uses a list of expected directory names to understand if it's
> being run from the top of a kernel tree. Commit 76128326f97c ("toplevel:
> Move ipc/ to kernel/ipc/: move the files") removed a toplevel directory, so
> checkpatch.pl need to update its list.
> 
> Signed-off-by: Giovanni Gherdovich <ggherdovich@...e.cz>
> ---
>  scripts/checkpatch.pl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 6fcc66afb088..93b8fd1eea57 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -1099,7 +1099,7 @@ sub top_of_kernel_tree {
>  	my @tree_check = (
>  		"COPYING", "CREDITS", "Kbuild", "MAINTAINERS", "Makefile",
>  		"README", "Documentation", "arch", "include", "drivers",
> -		"fs", "init", "ipc", "kernel", "lib", "scripts",
> +		"fs", "init", "kernel", "lib", "scripts",
>  	);
>  
>  	foreach my $check (@tree_check) {

Nope, this was already fixed by Yunfeng Ye with
https://lore.kernel.org/lkml/bd70558e-5126-6460-81d7-edf72cbbce7a@huawei.com/
plus the ipc/ directory is now back in its place.

Sorry for the noise,
Giovanni