linux-kernel - Re: libtraceevent installing in wrong folder

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191108120548.4118879a@gandalf.local.home>
Date:   Fri, 8 Nov 2019 12:05:48 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Sudip Mukherjee <sudipm.mukherjee@...il.com>
Cc:     linux-kernel <linux-kernel@...r.kernel.org>,
        Linux Trace Devel <linux-trace-devel@...r.kernel.org>
Subject: Re: libtraceevent installing in wrong folder


[ I also added linux-trace-devel, but it was good to Cc LKML too ]

On Fri, 8 Nov 2019 16:11:57 +0000
Sudip Mukherjee <sudipm.mukherjee@...il.com> wrote:

> Hi Steve,
> 
> I tried to install libtraceevent. and I used the command:
> "make DESTDIR=/home/sudip/test prefix=/usr install" from tool/lib/traceevent
> 
> And this is what I get:
> sudip@...ian:~/test$ pwd
> /home/sudip/test
> 
> sudip@...ian:~/test$ find .
> .
> ./usr
> ./usr/local
> ./usr/local/lib
> ./usr/local/lib/x86_64-linux-gnu
> ./usr/local/lib/x86_64-linux-gnu/pkgconfig
> ./usr/local/lib/x86_64-linux-gnu/pkgconfig/libtraceevent.pc
> ./usr/lib64
> ./usr/lib64/traceevent
> ./usr/lib64/traceevent/plugins
> ./usr/lib64/traceevent/plugins/plugin_hrtimer.so
> ./usr/lib64/traceevent/plugins/plugin_sched_switch.so
> ./usr/lib64/traceevent/plugins/plugin_jbd2.so
> ./usr/lib64/traceevent/plugins/plugin_kvm.so
> ./usr/lib64/traceevent/plugins/plugin_cfg80211.so
> ./usr/lib64/traceevent/plugins/plugin_kmem.so
> ./usr/lib64/traceevent/plugins/plugin_scsi.so
> ./usr/lib64/traceevent/plugins/plugin_mac80211.so
> ./usr/lib64/traceevent/plugins/plugin_function.so
> ./usr/lib64/traceevent/plugins/plugin_xen.so
> ./usr/lib64/libtraceevent.so
> ./usr/lib64/libtraceevent.so.1.1.0
> ./usr/lib64/libtraceevent.a
> ./usr/lib64/libtraceevent.so.1
> ./home
> ./home/sudip
> ./home/sudip/test
> ./home/sudip/test/usr
> ./home/sudip/test/usr/include
> ./home/sudip/test/usr/include/traceevent
> ./home/sudip/test/usr/include/traceevent/event-parse.h
> ./home/sudip/test/usr/include/traceevent/trace-seq.h
> ./home/sudip/test/usr/include/traceevent/kbuffer.h
> ./home/sudip/test/usr/include/traceevent/event-utils.h
> 
> I am seeing two problems:
> 1) It created another home/sudip/test folder inside /home/sudip/test and
> the header files are installed in /home/sudip/test/home/sudip/test/usr/include folder.
> They should have been in /home/sudip/test/usr/include.
> 
> 2) I used prefix=/usr but the 'pkgconfig' still went to /usr/local
> 
> Did I do something wrong?

No, but you showed that the installation part is poorly tested. I
mostly tested just the code from trace-cmd, and even the installation
paths from that repo. I should have tested the kernel repo as well, but
failed to do this.

Thanks for reporting, I need to take a look, or if you want to have a go
at it, that would be great too :-)

-- Steve