linux-kernel - Re: [PATCH v2 2/4] Bluetooth: btbcm: Support pcm configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 8 Nov 2019 07:11:24 +0100
From:   Marcel Holtmann <marcel@...tmann.org>
To:     Abhishek Pandit-Subedi <abhishekpandit@...omium.org>
Cc:     Johan Hedberg <johan.hedberg@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        linux-bluetooth@...r.kernel.org, dianders@...omium.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/4] Bluetooth: btbcm: Support pcm configuration

Hi Abhishek,

> Add BCM vendor specific commands to configure PCM.

please be a bit more descriptive and you can also add the command decoding from btmon here if you like.

> 
> Signed-off-by: Abhishek Pandit-Subedi <abhishekpandit@...omium.org>
> ---
> 
> Changes in v2: None
> 
> drivers/bluetooth/btbcm.c | 35 +++++++++++++++++++++++++++++++++++
> drivers/bluetooth/btbcm.h | 10 ++++++++++
> 2 files changed, 45 insertions(+)
> 
> diff --git a/drivers/bluetooth/btbcm.c b/drivers/bluetooth/btbcm.c
> index 2d2e6d862068..f052518f7b0c 100644
> --- a/drivers/bluetooth/btbcm.c
> +++ b/drivers/bluetooth/btbcm.c
> @@ -105,6 +105,41 @@ int btbcm_set_bdaddr(struct hci_dev *hdev, const bdaddr_t *bdaddr)
> }
> EXPORT_SYMBOL_GPL(btbcm_set_bdaddr);
> 
> +int btbcm_set_pcm_params(struct hci_dev *hdev,
> +			 const struct bcm_set_pcm_int_params *int_params,
> +			 const struct bcm_set_pcm_format_params *format_params)
> +{
> +	struct sk_buff *skb;
> +	int err;
> +
> +	if (int_params) {
> +		skb = __hci_cmd_sync(hdev, 0xfc1c, 5, int_params,
> +				     HCI_INIT_TIMEOUT);
> +		if (IS_ERR(skb)) {
> +			err = PTR_ERR(skb);
> +			bt_dev_err(hdev, "BCM: Set PCM int params failed (%d)",
> +				   err);
> +			return err;
> +		}
> +		kfree_skb(skb);
> +	}

Actually lets do btbcm_set_pcm_int_params and focus on the ones you are using right now.

Regards

Marcel