linux-kernel - Re: [PATCH 1/2] list: add hlist_unhashed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iKNLESN7U7BtyzkC6WLVn__Hm727A5cRm6PDuzG5+E4vA@mail.gmail.com>
Date:   Fri, 8 Nov 2019 12:17:49 -0800
From:   Eric Dumazet <edumazet@...gle.com>
To:     "Paul E. McKenney" <paulmck@...nel.org>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Eric Dumazet <eric.dumazet@...il.com>
Subject: Re: [PATCH 1/2] list: add hlist_unhashed_lockless()

On Fri, Nov 8, 2019 at 11:24 AM Paul E. McKenney <paulmck@...nel.org> wrote:
>
> On Thu, Nov 07, 2019 at 11:37:37AM -0800, Eric Dumazet wrote:
> > We would like to use hlist_unhashed() from timer_pending(),
> > which runs without protection of a lock.
> >
> > Note that other callers might also want to use this variant.
> >
> > Instead of forcing a READ_ONCE() for all hlist_unhashed()
> > callers, add a new helper with an explicit _lockless suffix
> > in the name to better document what is going on.
> >
> > Also add various WRITE_ONCE() in __hlist_del(), hlist_add_head()
> > and hlist_add_before()/hlist_add_behind() to pair with
> > the READ_ONCE().
> >
> > Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> > Cc: "Paul E. McKenney" <paulmck@...nel.org>
> > Cc: Thomas Gleixner <tglx@...utronix.de>
>
> I have queued this, but if you prefer it go some other way:
>
> Acked-by: Paul E. McKenney <paulmck@...nel.org>
>
> But shouldn't the uses in include/linux/rculist.h also be converted
> into the patch below?  If so, I will squash the following into your
> patch.
>
>                                                 Thanx, Paul
>
> ------------------------------------------------------------------------

Agreed, thanks for the addition of this Paul.