linux-kernel - Re: [PATCH 2/2] lib/xz: Fix XZ_DYNALLOC to avoid useless memory reallocations.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191108125020.3f927531189e9584f66adc10@linux-foundation.org>
Date:   Fri, 8 Nov 2019 12:50:20 -0800
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Daniel Walker <danielwa@...co.com>
Cc:     Lasse Collin <lasse.collin@...aani.org>, Yu Sun <yusun2@...co.com>,
        xe-linux-external@...co.com, Daniel Walker <dwalker@...o99.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] lib/xz: Fix XZ_DYNALLOC to avoid useless memory
 reallocations.

On Fri, 8 Nov 2019 12:27:54 -0800 Daniel Walker <danielwa@...co.com> wrote:

> On Fri, Nov 08, 2019 at 12:00:40PM -0800, Daniel Walker wrote:
> > From: Lasse Collin <lasse.collin@...aani.org>
> > 
> > s->dict.allocated was initialized to 0 but never set after
> > a successful allocation, thus the code always thought that
> > the dictionary buffer has to be reallocated.
> > 
> > For the original commit to xz-embedded.git, please refer to:
> > https://git.tukaani.org/?p=xz-embedded.git;a=commit;h=40d291b
> > 
> > Signed-off-by: Yu Sun <yusun2@...co.com>
> 
> 
> Yu made me aware that Lasse had sent this on Nov. 4. I would recommend you
> take that patch, and disregard this one. Cisco is using it and we would like
> to see it merged.

No probs.  I'll take that as an acked-by ;)