linux-kernel - Re: Potential uninitialized variable "reg" in clk: axi-clkgen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191108222839.07D7120865@mail.kernel.org>
Date:   Fri, 08 Nov 2019 14:28:38 -0800
From:   Stephen Boyd <sboyd@...nel.org>
To:     Chengyu Song <csong@...ucr.edu>,
        Michael Turquette <mturquette@...libre.com>,
        Yizhuo Zhai <yzhai003@....edu>,
        Zhiyun Qian <zhiyunq@...ucr.edu>, linux-clk@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: Potential uninitialized variable "reg" in clk: axi-clkgen

Quoting Yizhuo Zhai (2019-10-09 17:55:06)
> Hi All:
> drivers/clk/clk-axi-clkgen.c:
> 
> Inside function axi_clkgen_recalc_rate(), variable "reg" could be
> uninitialized if axi_clkgen_mmcm_read() fails. However, "reg" is used
> to decide the control flow later in the if statement, which is
> potentially unsafe.
> 
> The patch for this case is not easy since the error return is not an
> acceptable return value for axi_clkgen_recalc_rate().
> 

I think we will do nothing unless you send some sort of patch. Sorry.