linux-kernel - Re: [PATCH] ath10k: disable cpuidle during downloading firmware.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87bltmydkk.fsf@kamboji.qca.qualcomm.com>
Date:   Fri, 08 Nov 2019 10:31:07 +0200
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Tom Psyborg <pozega.tomislav@...il.com>
Cc:     netdev@...r.kernel.org, linux-wireless@...r.kernel.org,
        linux-kernel@...r.kernel.org, ath10k@...ts.infradead.org,
        Ikjoon Jang <ikjn@...omium.org>,
        "David S . Miller" <davem@...emloft.net>
Subject: Re: [PATCH] ath10k: disable cpuidle during downloading firmware.

Tom Psyborg <pozega.tomislav@...il.com> writes:

> On 06/11/2019, Kalle Valo <kvalo@...eaurora.org> wrote:
>> Ikjoon Jang <ikjn@...omium.org> writes:
>>
>>> Downloading ath10k firmware needs a large number of IOs and
>>> cpuidle's miss predictions make it worse. In the worst case,
>>> resume time can be three times longer than the average on sdio.
>>>
>>> This patch disables cpuidle during firmware downloading by
>>> applying PM_QOS_CPU_DMA_LATENCY in ath10k_download_fw().
>>>
>>> Signed-off-by: Ikjoon Jang <ikjn@...omium.org>
>>
>> On what hardware and firmware versions did you test this? I'll add that
>> to the commit log.
>
> I've tested this on QCA9880. No issues during firmware download.

Great, thanks for testing.

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches