linux-kernel - Re: [PATCH v2 03/11] ABI: Update FSI path documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <3563232.FuPAt9pb84@townsend>
Date:   Fri, 08 Nov 2019 20:27:47 +1100
From:   Alistair Popple <alistair@...ple.id.au>
To:     Joel Stanley <joel@....id.au>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Greg KH <gregkh@...uxfoundation.org>,
        Jeremy Kerr <jk@...abs.org>,
        Eddie James <eajames@...ux.ibm.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-fsi@...ts.ozlabs.org
Subject: Re: [PATCH v2 03/11] ABI: Update FSI path documentation

On Friday, 8 November 2019 4:19:37 PM AEDT Joel Stanley wrote:
> The paths added back in 4.13 weren't quite correct. The in reality the

Minor nit-pick, it should read "In reality the...". Otherwise looks reasonable.

Acked-by: Alistair Popple <alistair@...ple.id.au>

> files documented lived under
> 
>   /sys/devices/../fsi0/rescan
>   /sys/devices/../fsi0/break
>   /sys/devices/../fsi0/slave@00:00/term
>   /sys/devices/../fsi0/slave@00:00/raw
> 
> In 5.5 with the addition of the FSI class they move to
> 
>   /sys/devices/../fsi-master/fsi0/rescan
>   /sys/devices/../fsi-master/fsi0/break
>   /sys/devices/../fsi-master/fsi0/slave@00:00/term
>   /sys/devices/../fsi-master/fsi0/slave@00:00/raw
> 
> This is closer to how the (incorrect) documentation described them.
> 
> Signed-off-by: Joel Stanley <joel@....id.au>
> ---
>  Documentation/ABI/testing/sysfs-bus-fsi | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/Documentation/ABI/testing/sysfs-bus-fsi b/Documentation/ABI/testing/sysfs-bus-fsi
> index 57c806350d6c..320697bdf41d 100644
> --- a/Documentation/ABI/testing/sysfs-bus-fsi
> +++ b/Documentation/ABI/testing/sysfs-bus-fsi
> @@ -1,25 +1,25 @@
> -What:           /sys/bus/platform/devices/fsi-master/rescan
> +What:           /sys/bus/platform/devices/../fsi-master/fsi0/rescan
>  Date:		May 2017
>  KernelVersion:  4.12
> -Contact:        cbostic@...ux.vnet.ibm.com
> +Contact:        linux-fsi@...ts.ozlabs.org
>  Description:
>                  Initiates a FSI master scan for all connected slave devices
>  		on its links.
>  
> -What:           /sys/bus/platform/devices/fsi-master/break
> +What:           /sys/bus/platform/devices/../fsi-master/fsi0/break
>  Date:		May 2017
>  KernelVersion:  4.12
> -Contact:        cbostic@...ux.vnet.ibm.com
> +Contact:        linux-fsi@...ts.ozlabs.org
>  Description:
>  		Sends an FSI BREAK command on a master's communication
>  		link to any connnected slaves.  A BREAK resets connected
>  		device's logic and preps it to receive further commands
>  		from the master.
>  
> -What:           /sys/bus/platform/devices/fsi-master/slave@00:00/term
> +What:           /sys/bus/platform/devices/../fsi-master/fsi0/slave@00:00/term
>  Date:		May 2017
>  KernelVersion:  4.12
> -Contact:        cbostic@...ux.vnet.ibm.com
> +Contact:        linux-fsi@...ts.ozlabs.org
>  Description:
>  		Sends an FSI terminate command from the master to its
>  		connected slave. A terminate resets the slave's state machines
> @@ -29,10 +29,10 @@ Description:
>  		ongoing operation in case of an expired 'Master Time Out'
>  		timer.
>  
> -What:           /sys/bus/platform/devices/fsi-master/slave@00:00/raw
> +What:           /sys/bus/platform/devices/../fsi-master/fsi0/slave@00:00/raw
>  Date:		May 2017
>  KernelVersion:  4.12
> -Contact:        cbostic@...ux.vnet.ibm.com
> +Contact:        linux-fsi@...ts.ozlabs.org
>  Description:
>  		Provides a means of reading/writing a 32 bit value from/to a
>  		specified FSI bus address.
>