linux-kernel - Re: [PATCH v2 04/11] trace: fsi: Print transfer size unsigned

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <2120832.yXaHOgoxCj@townsend>
Date:   Fri, 08 Nov 2019 20:21:01 +1100
From:   Alistair Popple <alistair@...ple.id.au>
To:     Joel Stanley <joel@....id.au>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Greg KH <gregkh@...uxfoundation.org>,
        Jeremy Kerr <jk@...abs.org>, Andrew Jeffery <andrew@...id.au>,
        Eddie James <eajames@...ux.ibm.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-fsi@...ts.ozlabs.org
Subject: Re: [PATCH v2 04/11] trace: fsi: Print transfer size unsigned

Acked-by: Alistair Popple <alistair@...ple.id.au>

On Friday, 8 November 2019 4:19:38 PM AEDT Joel Stanley wrote:
> From: Andrew Jeffery <andrew@...id.au>
> 
> Due to other bugs I observed a spurious -1 transfer size.
> 
> Signed-off-by: Andrew Jeffery <andrew@...id.au>
> Signed-off-by: Joel Stanley <joel@....id.au>
> ---
>  include/trace/events/fsi.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/include/trace/events/fsi.h b/include/trace/events/fsi.h
> index 92e5e89e52ed..9832cb8e0eb0 100644
> --- a/include/trace/events/fsi.h
> +++ b/include/trace/events/fsi.h
> @@ -26,7 +26,7 @@ TRACE_EVENT(fsi_master_read,
>  		__entry->addr = addr;
>  		__entry->size = size;
>  	),
> -	TP_printk("fsi%d:%02d:%02d %08x[%zd]",
> +	TP_printk("fsi%d:%02d:%02d %08x[%zu]",
>  		__entry->master_idx,
>  		__entry->link,
>  		__entry->id,
> @@ -56,7 +56,7 @@ TRACE_EVENT(fsi_master_write,
>  		__entry->data = 0;
>  		memcpy(&__entry->data, data, size);
>  	),
> -	TP_printk("fsi%d:%02d:%02d %08x[%zd] <= {%*ph}",
> +	TP_printk("fsi%d:%02d:%02d %08x[%zu] <= {%*ph}",
>  		__entry->master_idx,
>  		__entry->link,
>  		__entry->id,
> @@ -93,7 +93,7 @@ TRACE_EVENT(fsi_master_rw_result,
>  		if (__entry->write || !__entry->ret)
>  			memcpy(&__entry->data, data, size);
>  	),
> -	TP_printk("fsi%d:%02d:%02d %08x[%zd] %s {%*ph} ret %d",
> +	TP_printk("fsi%d:%02d:%02d %08x[%zu] %s {%*ph} ret %d",
>  		__entry->master_idx,
>  		__entry->link,
>  		__entry->id,
>