linux-kernel - Re: [PATCH v5 06/13] drivers: irqchip: qcom-pdc: Move to an SoC independent compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9c2b33f2-02bb-e516-4cb5-b466757cd67a@codeaurora.org>
Date:   Fri, 8 Nov 2019 15:25:34 +0530
From:   Rajendra Nayak <rnayak@...eaurora.org>
To:     Marc Zyngier <maz@...nel.org>
Cc:     agross@...nel.org, robh+dt@...nel.org, bjorn.andersson@...aro.org,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, mka@...omium.org,
        swboyd@...omium.org, Lina Iyer <ilina@...eaurora.org>
Subject: Re: [PATCH v5 06/13] drivers: irqchip: qcom-pdc: Move to an SoC
 independent compatible


On 11/8/2019 3:10 PM, Marc Zyngier wrote:
> On 2019-11-08 10:37, Rajendra Nayak wrote:
>> Remove the sdm845 SoC specific compatible to make the driver
>> easily reusable across other SoC's with the same IP block.
>> This will reduce further churn adding any SoC specific
>> compatibles unless really needed.
>>
>> Signed-off-by: Rajendra Nayak <rnayak@...eaurora.org>
>> Reviewed-by: Lina Iyer <ilina@...eaurora.org>
>> Reviewed-by: Stephen Boyd <swboyd@...omium.org>
>> Cc: Marc Zyngier <maz@...nel.org>
>> ---
>>  drivers/irqchip/qcom-pdc.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/irqchip/qcom-pdc.c b/drivers/irqchip/qcom-pdc.c
>> index faa7d61b9d6c..c175333bb646 100644
>> --- a/drivers/irqchip/qcom-pdc.c
>> +++ b/drivers/irqchip/qcom-pdc.c
>> @@ -309,4 +309,4 @@ static int qcom_pdc_init(struct device_node
>> *node, struct device_node *parent)
>>      return ret;
>>  }
>>
>> -IRQCHIP_DECLARE(pdc_sdm845, "qcom,sdm845-pdc", qcom_pdc_init);
>> +IRQCHIP_DECLARE(qcom_pdc, "qcom,pdc", qcom_pdc_init);
> 
> Acked-by: Marc Zyngier <marc.zyngier@....com>
> 
> How do you want me get this (and the DT change) merged? I can either take
> these two patches in the irqchip tree, or you arrange them to be taken
> by the platform maintainers. Your call.

I think it makes sense for you to take these two via your tree (The driver
and binding doc updates) and the DT node addition for pdc to go via Andy/Bjorn.
Andy/Bjorn, does that sound fine?

-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation