linux-kernel - Re: [PATCH] intel-iommu: Turn off translations at shutdown

Open Source and information security mailing list archives

Message-ID: <b84d1349-f5e3-c778-4490-d81a7c82b30a@linux.intel.com>
Date:   Fri, 8 Nov 2019 11:07:02 +0800
From:   Lu Baolu <baolu.lu@...ux.intel.com>
To:     Deepa Dinamani <deepa.kernel@...il.com>, joro@...tes.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Cc:     baolu.lu@...ux.intel.com, iommu@...ts.linux-foundation.org,
        David Woodhouse <dwmw2@...radead.org>
Subject: Re: [PATCH] intel-iommu: Turn off translations at shutdown

Hi,

On 11/8/19 5:27 AM, Deepa Dinamani wrote:
> On Thu, Nov 7, 2019 at 12:59 PM Deepa Dinamani <deepa.kernel@...il.com> wrote:
>> +static void intel_iommu_shutdown(void)
>> +       if (no_iommu || dmar_disabled)
>> +               return;
> 
> This check is actually not required here, as the handler is only
> installed after these have been checked in intel_iommu_init.
> I can remove this in the next version of the patch, but I'll wait a
> few days for comments.

This is probably still necessary if moving to detect_intel_iommu().

Best regards,
baolu

> 
> -Deepa
> _______________________________________________
> iommu mailing list
> iommu@...ts.linux-foundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/iommu
> 

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives