lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 8 Nov 2019 13:36:40 +0000 From: Mirela Rabulea <mirela.rabulea@....com> To: "mchehab@...nel.org" <mchehab@...nel.org>, "shawnguo@...nel.org" <shawnguo@...nel.org>, "robh+dt@...nel.org" <robh+dt@...nel.org>, "hverkuil-cisco@...all.nl" <hverkuil-cisco@...all.nl> CC: dl-linux-imx <linux-imx@....com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "laurent.pinchart+renesas@...asonboard.com" <laurent.pinchart+renesas@...asonboard.com>, Aisheng Dong <aisheng.dong@....com>, Laurentiu Palcu <laurentiu.palcu@....com>, "paul.kocialkowski@...tlin.com" <paul.kocialkowski@...tlin.com>, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>, Robert Chiras <robert.chiras@....com>, "mark.rutland@....com" <mark.rutland@....com>, "p.zabel@...gutronix.de" <p.zabel@...gutronix.de>, "niklas.soderlund+renesas@...natech.se" <niklas.soderlund+renesas@...natech.se>, Daniel Baluta <daniel.baluta@....com>, Leonard Crestez <leonard.crestez@....com>, "dafna.hirschfeld@...labora.com" <dafna.hirschfeld@...labora.com>, "s.hauer@...gutronix.de" <s.hauer@...gutronix.de> Subject: Re: [EXT] Re: [PATCH 0/5] Add V4L2 driver for i.MX8 JPEG Encoder/Decoder Hi Hans, On Mi, 2019-11-06 at 17:52 +0100, Hans Verkuil wrote: > test Scaling: OK > The presence of a scaler is suspicious: is the encoder indeed > capable of scaling? I suspect this is a bug. No, it's not capable of scaling. You suspect a bug in the driver or the tests? > Codec ioctls: > > test VIDIOC_(TRY_)ENCODER_CMD: OK > The presence of this... > > > > > test VIDIOC_G_ENC_INDEX: OK (Not Supported) > > test VIDIOC_(TRY_)DECODER_CMD: OK > ...and this is also strange for a JPEG codec. These ioctls are > typically only > needed for MPEG/H264/etc. codecs, and not for a simple JPEG codec. > > The same issues are found for the JPEG decoder. I implemented the CMD_STOP for both encoder & decoder, because it was requested by our developer for gstreamer plugin for this codec. The context in which this was requested was for playing MJPEG videos (a concatenation of JPEG frames). > Streaming ioctls: > > test read/write: OK (Not Supported) > > test blocking wait: OK > > fail: v4l2-test-buffers.cpp(254): g_field() == > > V4L2_FIELD_ANY > The driver shall never return FIELD_ANY. This needs to be FIELD_NONE. Is there a "good example" of a v4l m2m driver that passes these streaming tests? That would save some time on my side. For the FIELD_ANY issue, I got inspired from your commit: ab7afaf3 media: vim2m: add buf_out_validate callback But there's a lot more to go... Thanks, Mirela
Powered by blists - more mailing lists