linux-kernel - Re: [PATCH 4/8] ipmi: kill off 'timespec' usage again

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a3BybzufBLVr-n5hCuxOt-MK=0qs9F7b3DYhZ58jiv7vw@mail.gmail.com>
Date:   Sat, 9 Nov 2019 12:23:00 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     cminyard@...sta.com
Cc:     y2038 Mailman List <y2038@...ts.linaro.org>,
        Corey Minyard <minyard@....org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        openipmi-developer@...ts.sourceforge.net
Subject: Re: [PATCH 4/8] ipmi: kill off 'timespec' usage again

On Fri, Nov 8, 2019 at 11:11 PM Corey Minyard <cminyard@...sta.com> wrote:
>
> On Fri, Nov 08, 2019 at 09:34:27PM +0100, Arnd Bergmann wrote:
> > 'struct timespec' is getting removed from the kernel. The usage in ipmi
> > was fixed before in commit 48862ea2ce86 ("ipmi: Update timespec usage
> > to timespec64"), but unfortunately it crept back in.
> >
> > The busy looping code can better use ktime_t anyway, so use that
> > there to simplify the implementation.
>
> Thanks, this is a big improvement.  I have this queued, but if you
> are going to submit this, I can remove it, and:
>
> Reviewed-by: Corey Minyard <cminyard@...sta.com>

I'd prefer to have this go through your tree, one less thing for me
to worry about (out of the 90 patches).

> Do you think this should go in to 5.4?

Up to you, it probably depends on how well you can test that the change
is correct beyond the review.

       Arnd