linux-kernel - Re: [PATCH 2/4] dt-bindings: iio: timer: Convert stm32 IIO trigger bindings to json-schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191109124301.5ffda04b@archlinux>
Date:   Sat, 9 Nov 2019 12:43:01 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     Rob Herring <robh@...nel.org>
Cc:     Benjamin GAIGNARD <benjamin.gaignard@...com>,
        Benjamin Gaignard <benjamin.gaignard@...aro.org>,
        Mark Rutland <mark.rutland@....com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Alexandre TORGUE <alexandre.torgue@...com>,
        Linux PWM List <linux-pwm@...r.kernel.org>,
        "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
        "u.kleine-koenig@...gutronix.de" <u.kleine-koenig@...gutronix.de>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Thierry Reding <thierry.reding@...il.com>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        Hartmut Knaack <knaack.h@....de>,
        Fabrice GASNIER <fabrice.gasnier@...com>,
        Lee Jones <lee.jones@...aro.org>,
        "linux-stm32@...md-mailman.stormreply.com" 
        <linux-stm32@...md-mailman.stormreply.com>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 2/4] dt-bindings: iio: timer: Convert stm32 IIO trigger
 bindings to json-schema

On Wed, 6 Nov 2019 17:35:20 -0600
Rob Herring <robh@...nel.org> wrote:

> On Wed, Nov 6, 2019 at 1:52 PM Benjamin GAIGNARD
> <benjamin.gaignard@...com> wrote:
> >
> >
> > On 11/6/19 5:06 AM, Rob Herring wrote:  
> > > On Tue, Nov 05, 2019 at 11:07:16AM +0100, Benjamin Gaignard wrote:  
> > >> Le dim. 3 nov. 2019 à 12:08, Jonathan Cameron <jic23@...nel.org> a écrit :  
> > >>> On Thu, 31 Oct 2019 13:30:38 +0100
> > >>> Benjamin Gaignard <benjamin.gaignard@...com> wrote:
> > >>>  
> > >>>> Convert the STM32 IIO trigger binding to DT schema format using json-schema
> > >>>>
> > >>>> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@...com>  
> > >>> I'm far from great on these as still haven't taken the time I should to learn
> > >>> the yaml syntax properly.  A few comments inline however based mostly on this
> > >>> doesn't quite look like other ones I've seen recently.
> > >>>
> > >>> Thanks,
> > >>>
> > >>> Jonathan
> > >>>  
> > >>>> ---
> > >>>>   .../bindings/iio/timer/st,stm32-timer-trigger.yaml | 44 ++++++++++++++++++++++
> > >>>>   .../bindings/iio/timer/stm32-timer-trigger.txt     | 25 ------------
> > >>>>   2 files changed, 44 insertions(+), 25 deletions(-)
> > >>>>   create mode 100644 Documentation/devicetree/bindings/iio/timer/st,stm32-timer-trigger.yaml
> > >>>>   delete mode 100644 Documentation/devicetree/bindings/iio/timer/stm32-timer-trigger.txt
> > >>>>
> > >>>> diff --git a/Documentation/devicetree/bindings/iio/timer/st,stm32-timer-trigger.yaml b/Documentation/devicetree/bindings/iio/timer/st,stm32-timer-trigger.yaml
> > >>>> new file mode 100644
> > >>>> index 000000000000..1c8c8b55e8cd
> > >>>> --- /dev/null
> > >>>> +++ b/Documentation/devicetree/bindings/iio/timer/st,stm32-timer-trigger.yaml
> > >>>> @@ -0,0 +1,44 @@
> > >>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > >>>> +%YAML 1.2
> > >>>> +---
> > >>>> +$id: http://devicetree.org/schemas/iio/timer/st,stm32-timer-trigger.yaml#
> > >>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > >>>> +
> > >>>> +title: STMicroelectronics STM32 Timers IIO timer bindings
> > >>>> +
> > >>>> +maintainers:
> > >>>> +  - Benjamin Gaignard <benjamin.gaignard@...com>
> > >>>> +  - Fabrice Gasnier <fabrice.gasnier@...com>
> > >>>> +
> > >>>> +properties:
> > >>>> +  $nodemane:  
> > >>> nodename?  
> > >> That will be in v2  
> > > No, $nodename is correct. The '$' signifies something we generate and
> > > add in. IOW, not a real property. I guess we could have used 'name' here
> > > and stuck with traditional OpenFirmware.  
> > let's go for $name  
> 
> No, $nodename is correct. You don't have a choice. That is what the
> tooling generates.

Sorry all, I caused confusion here.  Was just trying to point out the typo!
$node_m_ane

:)

> 
> Rob