linux-kernel - Re: [PATCH 1/3] fs/userfaultfd.c: remove a redundant check on end

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191109012936.fkqdczhl3sykius7@master>
Date:   Sat, 9 Nov 2019 01:29:36 +0000
From:   Wei Yang <richard.weiyang@...il.com>
To:     Wei Yang <richardw.yang@...ux.intel.com>
Cc:     viro@...iv.linux.org.uk, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] fs/userfaultfd.c: remove a redundant check on end

On Fri, Sep 13, 2019 at 05:31:08AM +0800, Wei Yang wrote:
>For the ending vma, there is a check to make sure the end is huge page
>aligned.
>
>The *if* check makes sure vm_start < end <= vm_end. While the first half
>is not necessary, because the *for* clause makes sure vm_start < end.
>
>This patch just removes it.
>

Does this one look good?

>Signed-off-by: Wei Yang <richardw.yang@...ux.intel.com>
>---
> fs/userfaultfd.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
>diff --git a/fs/userfaultfd.c b/fs/userfaultfd.c
>index 653d8f7c453c..9ce09ac619a2 100644
>--- a/fs/userfaultfd.c
>+++ b/fs/userfaultfd.c
>@@ -1402,8 +1402,7 @@ static int userfaultfd_register(struct userfaultfd_ctx *ctx,
> 		 * If this vma contains ending address, and huge pages
> 		 * check alignment.
> 		 */
>-		if (is_vm_hugetlb_page(cur) && end <= cur->vm_end &&
>-		    end > cur->vm_start) {
>+		if (is_vm_hugetlb_page(cur) && end <= cur->vm_end) {
> 			unsigned long vma_hpagesize = vma_kernel_pagesize(cur);
> 
> 			ret = -EINVAL;
>-- 
>2.17.1

-- 
Wei Yang
Help you, Help me