linux-kernel - Re: [PATCH] vsock/virtio: fix sock refcnt holding during the shutdown

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191108.121946.1084660860645163442.davem@davemloft.net>
Date:   Fri, 08 Nov 2019 12:19:46 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     sgarzare@...hat.com
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        smbarber@...omium.org, stefanha@...hat.com, kvm@...r.kernel.org,
        virtualization@...ts.linux-foundation.org
Subject: Re: [PATCH] vsock/virtio: fix sock refcnt holding during the
 shutdown

From: Stefano Garzarella <sgarzare@...hat.com>
Date: Fri,  8 Nov 2019 17:08:50 +0100

> The "42f5cda5eaf4" commit rightly set SOCK_DONE on peer shutdown,
> but there is an issue if we receive the SHUTDOWN(RDWR) while the
> virtio_transport_close_timeout() is scheduled.
> In this case, when the timeout fires, the SOCK_DONE is already
> set and the virtio_transport_close_timeout() will not call
> virtio_transport_reset() and virtio_transport_do_close().
> This causes that both sockets remain open and will never be released,
> preventing the unloading of [virtio|vhost]_transport modules.
> 
> This patch fixes this issue, calling virtio_transport_reset() and
> virtio_transport_do_close() when we receive the SHUTDOWN(RDWR)
> and there is nothing left to read.
> 
> Fixes: 42f5cda5eaf4 ("vsock/virtio: set SOCK_DONE on peer shutdown")
> Cc: Stephen Barber <smbarber@...omium.org>
> Signed-off-by: Stefano Garzarella <sgarzare@...hat.com>

Applied and queued up for -stable, thanks.