linux-kernel - Re: [PATCH] mm: fixmap: convert __set_fixmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 10 Nov 2019 06:49:17 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Arnd Bergmann <arnd@...db.de>, linux-arch@...r.kernel.org
Subject: Re: [PATCH] mm: fixmap: convert __set_fixmap_offset() to an inline
 function

Hi Masahiro,

I love your patch! Yet something to improve:

[auto build test ERROR on mmotm/master]
[also build test ERROR on v5.4-rc6 next-20191108]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Masahiro-Yamada/mm-fixmap-convert-__set_fixmap_offset-to-an-inline-function/20191110-045158
base:   git://git.cmpxchg.org/linux-mmotm.git master
config: powerpc-defconfig (attached as .config)
compiler: powerpc64-linux-gcc (GCC) 7.4.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.4.0 make.cross ARCH=powerpc 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   In file included from arch/powerpc/include/asm/fixmap.h:75:0,
                    from arch/powerpc/mm/mem.c:48:
   include/asm-generic/fixmap.h: In function '__set_fixmap_offset':
   include/asm-generic/fixmap.h:78:2: error: implicit declaration of function '__set_fixmap'; did you mean 'set_fixmap'? [-Werror=implicit-function-declaration]
     __set_fixmap(idx, phys, flags);
     ^~~~~~~~~~~~
     set_fixmap
   In file included from arch/powerpc/mm/mem.c:48:0:
   arch/powerpc/include/asm/fixmap.h: At top level:
   arch/powerpc/include/asm/fixmap.h:77:20: error: conflicting types for '__set_fixmap' [-Werror]
    static inline void __set_fixmap(enum fixed_addresses idx,
                       ^~~~~~~~~~~~
>> arch/powerpc/include/asm/fixmap.h:77:20: error: static declaration of '__set_fixmap' follows non-static declaration
   In file included from arch/powerpc/include/asm/fixmap.h:75:0,
                    from arch/powerpc/mm/mem.c:48:
   include/asm-generic/fixmap.h:78:2: note: previous implicit declaration of '__set_fixmap' was here
     __set_fixmap(idx, phys, flags);
     ^~~~~~~~~~~~
   cc1: all warnings being treated as errors

vim +/__set_fixmap +77 arch/powerpc/include/asm/fixmap.h

2c419bdeca1d95 include/asm-powerpc/fixmap.h      Kumar Gala       2008-04-23  76  
4cfac2f9c7f116 arch/powerpc/include/asm/fixmap.h Christophe Leroy 2017-08-02 @77  static inline void __set_fixmap(enum fixed_addresses idx,
4cfac2f9c7f116 arch/powerpc/include/asm/fixmap.h Christophe Leroy 2017-08-02  78  				phys_addr_t phys, pgprot_t flags)
4cfac2f9c7f116 arch/powerpc/include/asm/fixmap.h Christophe Leroy 2017-08-02  79  {
c766ee72235d09 arch/powerpc/include/asm/fixmap.h Christophe Leroy 2018-10-09  80  	map_kernel_page(fix_to_virt(idx), phys, flags);
4cfac2f9c7f116 arch/powerpc/include/asm/fixmap.h Christophe Leroy 2017-08-02  81  }
4cfac2f9c7f116 arch/powerpc/include/asm/fixmap.h Christophe Leroy 2017-08-02  82  

:::::: The code at line 77 was first introduced by commit
:::::: 4cfac2f9c7f116af8516d0b3d0e7383189eca376 powerpc/mm: Simplify __set_fixmap()

:::::: TO: Christophe Leroy <christophe.leroy@....fr>
:::::: CC: Michael Ellerman <mpe@...erman.id.au>

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (25378 bytes)