linux-kernel - Re: [PATCH] iio: temperature: ltc2983: fix u32 read into a unsigned long long

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 10 Nov 2019 11:48:23 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     "Sa, Nuno" <Nuno.Sa@...log.com>
Cc:     "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
        "Jonathan.Cameron@...wei.com" <Jonathan.Cameron@...wei.com>,
        "colin.king@...onical.com" <colin.king@...onical.com>,
        "knaack.h@....de" <knaack.h@....de>,
        "pmeerw@...erw.net" <pmeerw@...erw.net>,
        "lars@...afoo.de" <lars@...afoo.de>,
        "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] iio: temperature: ltc2983: fix u32 read into a unsigned
 long long

On Wed, 6 Nov 2019 14:19:52 +0000
"Sa, Nuno" <Nuno.Sa@...log.com> wrote:

> On Tue, 2019-11-05 at 20:28 +0000, Colin King wrote:
> > 
> > From: Colin Ian King <colin.king@...onical.com>
> > 
> > Currently the read of temp using of_property_read_u32_index is
> > reading
> > a u32 value into a unsigned long long.  This relies on machine
> > endianness
> > to work correctly, so fix this by reading a u32 value and setting
> > temp
> > to this value.
> > 
> > Addresses-Coverity: ("Reliance on integer endianness")
> > Fixes: f110f3188e56 ("iio: temperature: Add support for LTC2983")
> > Signed-off-by: Colin Ian King <colin.king@...onical.com>
> > ---
> >  drivers/iio/temperature/ltc2983.c | 6 ++++--
> >  1 file changed, 4 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/iio/temperature/ltc2983.c
> > b/drivers/iio/temperature/ltc2983.c
> > index ddf47023364b..d39c0d6b77f1 100644
> > --- a/drivers/iio/temperature/ltc2983.c
> > +++ b/drivers/iio/temperature/ltc2983.c
> > @@ -444,8 +444,10 @@ static struct ltc2983_custom_sensor
> > *__ltc2983_custom_sensor_new(
> >  			else
> >  				temp = __convert_to_raw(temp,
> > resolution);
> >  		} else {
> > -			of_property_read_u32_index(np, propname, index,
> > -						   (u32 *)&temp);
> > +			u32 t32;
> > +
> > +			of_property_read_u32_index(np, propname, index,
> > &t32);
> > +			temp = t32;
> >  		}
> >  
> >  		for (j = 0; j < n_size; j++)  
> 
> Acked-by: Nuno Sá <nuno.sa@...log.com>
> 

A slight complexity around this one. I'm not sure I'll have time for a pull
before the merge window (as Greg will only take them to about 1 week before
that opens so we get some exposure in Linux next).

As a result I'll have to sit on this one until Linus comments on rc7, probably
later today.  Otherwise it'll be material for stable post release.

If I seem to have lost it give me a poke and we'll make sure it goes into 
an early rc instead of at the merge window.

Thanks,

Jonathan

> Thanks,
> Nuno Sá