linux-kernel - Re: [patch 2/9] x86/process: Unify copy_thread

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.1911101332490.12583@nanos.tec.linutronix.de>
Date:   Sun, 10 Nov 2019 13:36:04 +0100 (CET)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Andy Lutomirski <luto@...nel.org>
cc:     LKML <linux-kernel@...r.kernel.org>, x86@...nel.org,
        Stephen Hemminger <stephen@...workplumber.org>,
        Willy Tarreau <w@....eu>, Juergen Gross <jgross@...e.com>,
        Sean Christopherson <sean.j.christopherson@...el.com>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        "H. Peter Anvin" <hpa@...or.com>
Subject: Re: [patch 2/9] x86/process: Unify copy_thread_tls()

On Sat, 9 Nov 2019, Thomas Gleixner wrote:
> On Fri, 8 Nov 2019, Andy Lutomirski wrote:
> > On 11/6/19 11:35 AM, Thomas Gleixner wrote:
> > > +static inline int copy_io_bitmap(struct task_struct *tsk)
> > > +{
> > > +	if (likely(!test_tsk_thread_flag(current, TIF_IO_BITMAP)))
> > > +		return 0;
> > > +
> > > +	tsk->thread.io_bitmap_ptr = kmemdup(current->thread.io_bitmap_ptr,
> > > +					    IO_BITMAP_BYTES, GFP_KERNEL);
> > 
> > tsk->thread.io_bitmap_max = current->thread.io_bitmap_max?
> > 
> > I realize you inherited this from the code you're refactoring, but it
> > does seem to be missing.
> 
> It already got copied with the task struct :)
>  
> > > +#ifdef CONFIG_X86_64
> > > +	savesegment(gs, p->thread.gsindex);
> > > +	p->thread.gsbase = p->thread.gsindex ? 0 : current->thread.gsbase;
> > > +	savesegment(fs, p->thread.fsindex);
> > > +	p->thread.fsbase = p->thread.fsindex ? 0 : current->thread.fsbase;
> > > +	savesegment(es, p->thread.es);
> > > +	savesegment(ds, p->thread.ds);
> > > +#else
> > > +	/* Clear all status flags including IF and set fixed bit. */
> > > +	frame->flags = X86_EFLAGS_FIXED;
> > > +#endif
> > 
> > Want to do another commit to make the eflags fixup unconditional?  I'm
> > wondering if we have a bug.
> 
> Let me look at that.

64bit does not have flags in the inactive_task_frame ...

Thanks,

	tglx