linux-kernel - Re: [PATCH v2] cpuidle: Use nanoseconds as the unit of time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 10 Nov 2019 17:48:21 +0100
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Doug Smythies <dsmythies@...us.net>
Cc:     "Rafael J. Wysocki" <rafael@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Giovanni Gherdovich <ggherdovich@...e.cz>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Linux PM <linux-pm@...r.kernel.org>
Subject: Re: [PATCH v2] cpuidle: Use nanoseconds as the unit of time

On Fri, Nov 8, 2019 at 6:04 PM Doug Smythies <dsmythies@...us.net> wrote:
>
> On 2019.11.08 01:45 Rafael J. Wysocki wrote:
> > On Fri, Nov 8, 2019 at 9:45 AM Doug Smythies <dsmythies@...us.net> wrote:
> >
> ...
> >> I have been running this v2 today, with both menu and teo
> >> governors. Acquiring some baseline reference data to compare
> >> to now. The menu governor response seems different (Supporting
> >> information/graphs will come later).
> >
> > That may be good or bad, depending in what way it is different. :-)
>
> My thinking was that the differences should be minimal between
> the baseline (linux-next as of 2019.11.07) and plus your two patches.
> Because this was a change of units, but not functionality.
> Such is the case with the teo governor, but not the menu governor.
> I have not tried the ladder or haltpoll governors, and don't intend to.
>
> Now to attempt to isolate the issue in the code, which might take
> considerable time.

Thanks!

It looks like I have overlooked a unit conversion in menu or done a
unit conversion twice somewhere.