linux-kernel - Re: [PATCH] serial: 8250-mtk: Use platform_get_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1e18621e-fa29-eae8-8720-45d6f75caf7c@gmail.com>
Date:   Sun, 10 Nov 2019 21:23:24 +0100
From:   Matthias Brugger <matthias.bgg@...il.com>
To:     Frank Wunderlich <frank-w@...lic-files.de>,
        linux-mediatek@...ts.infradead.org
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-serial@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] serial: 8250-mtk: Use platform_get_irq_optional() for
 optional irq



On 27/10/2019 07:21, Frank Wunderlich wrote:
> As platform_get_irq() now prints an error when the interrupt does not
> exist, this warnings are printed on bananapi-r2:
> 
> [    4.935780] mt6577-uart 11004000.serial: IRQ index 1 not found
> [    4.962589] 11002000.serial: ttyS1 at MMIO 0x11002000 (irq = 202, base_baud = 1625000) is a ST16650V2
> [    4.972127] mt6577-uart 11002000.serial: IRQ index 1 not found
> [    4.998927] 11003000.serial: ttyS2 at MMIO 0x11003000 (irq = 203, base_baud = 1625000) is a ST16650V2
> [    5.008474] mt6577-uart 11003000.serial: IRQ index 1 not found
> 
> Fix this by calling platform_get_irq_optional() instead.
> 
> now it looks like this:
> 
> [    4.872751] Serial: 8250/16550 driver, 4 ports, IRQ sharing disabled
> 
> Fixes: 7723f4c5ecdb8d83 ("driver core: platform: Add an error message to platform_get_irq*()")
> 
> Signed-off-by: Frank Wunderlich <frank-w@...lic-files.de>

Reviewed-by: Matthias Brugger <matthias.bgg@...il.com>

> ---
> changes since v1:
> 	https://patchwork.kernel.org/patch/11213813/
> 	change from platform_irq_count to platform_get_irq_optional
> ---
>  drivers/tty/serial/8250/8250_mtk.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/8250/8250_mtk.c b/drivers/tty/serial/8250/8250_mtk.c
> index b411ba4eb5e9..4d067f515f74 100644
> --- a/drivers/tty/serial/8250/8250_mtk.c
> +++ b/drivers/tty/serial/8250/8250_mtk.c
> @@ -544,7 +544,7 @@ static int mtk8250_probe(struct platform_device *pdev)
>  	pm_runtime_set_active(&pdev->dev);
>  	pm_runtime_enable(&pdev->dev);
>  
> -	data->rx_wakeup_irq = platform_get_irq(pdev, 1);
> +	data->rx_wakeup_irq = platform_get_irq_optional(pdev, 1);
>  
>  	return 0;
>  }
>