[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CH2PR02MB63595AA5F7192DA2186EAC5CCB750@CH2PR02MB6359.namprd02.prod.outlook.com>
Date: Sun, 10 Nov 2019 22:18:10 +0000
From: Dragan Cvetic <draganc@...inx.com>
To: Markus Elfring <Markus.Elfring@....de>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>,
Arnd Bergmann <arnd@...db.de>,
Derek Kiernan <dkiernan@...inx.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Michal Simek <michals@...inx.com>
CC: LKML <linux-kernel@...r.kernel.org>,
"kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
Subject: RE: [PATCH 1/2] misc: xilinx_sdfec: Use memdup_user() rather than
duplicating its implementation
Hi Markus,
> -----Original Message-----
> From: Markus Elfring [mailto:Markus.Elfring@....de]
> Sent: Tuesday 5 November 2019 18:55
> To: linux-arm-kernel@...ts.infradead.org; Arnd Bergmann <arnd@...db.de>; Derek Kiernan <dkiernan@...inx.com>; Dragan Cvetic
> <draganc@...inx.com>; Greg Kroah-Hartman <gregkh@...uxfoundation.org>; Michal Simek <michals@...inx.com>
> Cc: LKML <linux-kernel@...r.kernel.org>; kernel-janitors@...r.kernel.org
> Subject: [PATCH 1/2] misc: xilinx_sdfec: Use memdup_user() rather than duplicating its implementation
>
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Tue, 5 Nov 2019 19:09:15 +0100
>
> Reuse existing functionality from memdup_user() instead of keeping
> duplicate source code.
>
> Generated by: scripts/coccinelle/api/memdup_user.cocci
>
> Fixes: 20ec628e8007ec75c2f884e00004f39eab6289b5 ("misc: xilinx_sdfec: Add ability to configure LDPC")
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
> ---
> drivers/misc/xilinx_sdfec.c | 11 +++--------
> 1 file changed, 3 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/misc/xilinx_sdfec.c b/drivers/misc/xilinx_sdfec.c
> index 11835969e982..a622fcf4954a 100644
> --- a/drivers/misc/xilinx_sdfec.c
> +++ b/drivers/misc/xilinx_sdfec.c
> @@ -649,14 +649,9 @@ static int xsdfec_add_ldpc(struct xsdfec_dev *xsdfec, void __user *arg)
> struct xsdfec_ldpc_params *ldpc;
> int ret, n;
>
> - ldpc = kzalloc(sizeof(*ldpc), GFP_KERNEL);
> - if (!ldpc)
> - return -ENOMEM;
> -
> - if (copy_from_user(ldpc, arg, sizeof(*ldpc))) {
> - ret = -EFAULT;
> - goto err_out;
> - }
> + ldpc = memdup_user(arg, sizeof(*ldpc));
> + if (IS_ERR(ldpc))
> + return PTR_ERR(ldpc);
Acked-by: Dragan Cvetic <dragan.cvetic@...inx.com>
>
> if (xsdfec->config.code == XSDFEC_TURBO_CODE) {
> ret = -EIO;
> --
> 2.24.0
Powered by blists - more mailing lists