linux-kernel - Re: [PATCH] usb: gadget: udc: lpc32xx: don't dereference ep until it has been null checked

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0e5105e3-768e-c8eb-dd73-d097bb7edfb2@mleia.com>
Date:   Mon, 11 Nov 2019 00:53:11 +0200
From:   Vladimir Zapolskiy <vz@...ia.com>
To:     Colin King <colin.king@...onical.com>,
        Felipe Balbi <balbi@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Sylvain Lemieux <slemieux.tyco@...il.com>,
        Roland Stigge <stigge@...com.de>,
        Arnd Bergmann <arnd@...db.de>, linux-usb@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: gadget: udc: lpc32xx: don't dereference ep until it
 has been null checked

On 11/11/2019 12:14 AM, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> The pointer ep is currently being dereferenced when initializing pointer
> udc before ep is being null checked.  Fix this by only dereferencing
> ep after it has been null checked.
> 
> Addresses-Coverity: ("Dereference before null check")
> Fixes: 24a28e428351 ("USB: gadget driver for LPC32xx")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Acked-by: Vladimir Zapolskiy <vz@...ia.com>

--
Best wishes,
Vladimir