linux-kernel - Re: [PATCH] ima: avoid appraise error for hash calc interrupt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 11 Nov 2019 14:29:52 -0800
From:   Lakshmi Ramasubramanian <nramas@...ux.microsoft.com>
To:     Patrick Callaghan <patrickc@...ux.ibm.com>,
        linux-integrity@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Mimi Zohar <zohar@...ux.ibm.com>
Subject: Re: [PATCH] ima: avoid appraise error for hash calc interrupt

On 11/11/19 11:23 AM, Patrick Callaghan wrote:

> -		if (rbuf_len == 0)
> +		if (rbuf_len == 0) {	/* unexpected EOF */
> +			rc = -EINVAL;
>   			break;
> +		}
>   		offset += rbuf_len;

Should there be an additional check to validate that (offset + rbuf_len) 
is less than i_size before calling cypto_shash_update (since rbuf_len is 
one of the parameters for this call)?

                if ((rbuf_len == 0) || (offset + rbuf_len >= i_size)) {
                         rc = -EINVAL;
                         break;
                }
                offset += rbuf_len;

>   	       rc = crypto_shash_update(shash, rbuf, rbuf_len);

  -lakshmi