linux-kernel - Re: [PATCH 1/4] irq_work: Convert flags to atomic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 11 Nov 2019 23:56:11 +0100
From:   Frederic Weisbecker <frederic@...nel.org>
To:     Ingo Molnar <mingo@...nel.org>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        LKML <linux-kernel@...r.kernel.org>,
        "Paul E . McKenney" <paulmck@...ux.vnet.ibm.com>,
        Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH 1/4] irq_work: Convert flags to atomic_t

On Mon, Nov 11, 2019 at 09:00:58AM +0100, Ingo Molnar wrote:
> 
> * Frederic Weisbecker <frederic@...nel.org> wrote:
> 
> > We need to convert flags to atomic_t in order to later fix an ordering
> > issue on cmpxchg() failure. This will allow us to use atomic_fetch_or().
> > Also that clarify the nature of those flags.
> > 
> > Signed-off-by: Frederic Weisbecker <frederic@...nel.org>
> > Cc: Paul E. McKenney <paulmck@...ux.vnet.ibm.com>
> > Cc: Thomas Gleixner <tglx@...utronix.de>
> > Cc: Peter Zijlstra <peterz@...radead.org>
> > Cc: Ingo Molnar <mingo@...nel.org>
> > ---
> >  include/linux/irq_work.h | 10 +++++++---
> >  kernel/irq_work.c        | 18 +++++++++---------
> >  kernel/printk/printk.c   |  2 +-
> >  3 files changed, 17 insertions(+), 13 deletions(-)
> 
> You missed the irq_work use in kernel/bpf/stackmap.c - see the fix below.
> 
> Thanks,
> 
> 	Ingo

Oh thanks. Strange that I haven't seen a 0-day warning about those.