linux-kernel - Re: [PATCH] powerpc: add const qual to local

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 12 Nov 2019 10:38:56 +1100
From:   Michael Ellerman <mpe@...erman.id.au>
To:     Eric Dumazet <edumazet@...gle.com>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>
Cc:     linux-kernel <linux-kernel@...r.kernel.org>,
        "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Eric Dumazet <eric.dumazet@...il.com>,
        kbuild test robot <lkp@...el.com>
Subject: Re: [PATCH] powerpc: add const qual to local_read() parameter

Eric Dumazet <edumazet@...gle.com> writes:
> A patch in net-next triggered a compile error on powerpc.

Would be nice to mention the compiler error, I haven't seen the report.

> This seems reasonable to relax powerpc local_read() requirements.

Seems fine.

Acked-by: Michael Ellerman <mpe@...erman.id.au>

Dave can you please put this in net-next to limit the window of
breakage.

cheers

> Fixes: 316580b69d0a ("u64_stats: provide u64_stats_t type")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: kbuild test robot <lkp@...el.com>
> Cc:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
> Cc:	Paul Mackerras <paulus@...ba.org>
> Cc:	Michael Ellerman <mpe@...erman.id.au>
> Cc:	linuxppc-dev@...ts.ozlabs.org

Seems it didn't actually get cc'ed to linuxppc-dev for some reason.

> ---
>  arch/powerpc/include/asm/local.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/include/asm/local.h b/arch/powerpc/include/asm/local.h
> index fdd00939270bf08113b537a090d6a6e34a048361..bc4bd19b7fc235b80ec1132f44409b6fe1057975 100644
> --- a/arch/powerpc/include/asm/local.h
> +++ b/arch/powerpc/include/asm/local.h
> @@ -17,7 +17,7 @@ typedef struct
>  
>  #define LOCAL_INIT(i)	{ (i) }
>  
> -static __inline__ long local_read(local_t *l)
> +static __inline__ long local_read(const local_t *l)
>  {
>  	return READ_ONCE(l->v);
>  }
> -- 
> 2.24.0.432.g9d3f5f5b63-goog