[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 11 Nov 2019 15:39:31 -0800
From: Andrew Morton <akpm@...ux-foundation.org>
To: "Maciej S. Szmigiero" <mail@...iej.szmigiero.name>
Cc: Seth Jennings <sjenning@...hat.com>,
Dan Streetman <ddstreet@...e.org>,
Vitaly Wool <vitalywool@...il.com>,
Vlastimil Babka <vbabka@...e.cz>, linux-mm@...ck.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] zswap: allow setting default status, compressor and
allocator in Kconfig
On Sat, 9 Nov 2019 00:51:07 +0100 "Maciej S. Szmigiero" <mail@...iej.szmigiero.name> wrote:
> The compressed cache for swap pages (zswap) currently needs from 1 to 3
> extra kernel command line parameters in order to make it work: it has to be
> enabled by adding a "zswap.enabled=1" command line parameter and if one
> wants a different compressor or pool allocator than the default lzo / zbud
> combination then these choices also need to be specified on the kernel
> command line in additional parameters.
>
> Using a different compressor and allocator for zswap is actually pretty
> common as guides often recommend using the lz4 / z3fold pair instead of
> the default one.
> In such case it is also necessary to remember to enable the appropriate
> compression algorithm and pool allocator in the kernel config manually.
>
> Let's avoid the need for adding these kernel command line parameters and
> automatically pull in the dependencies for the selected compressor
> algorithm and pool allocator by adding an appropriate default switches to
> Kconfig.
>
> The default values for these options match what the code was using
> previously as its defaults.
Shouldn't there be a Documentation/ update along with this change?
Powered by blists - more mailing lists