linux-kernel - Re: [PATCH 11/21] asm-generic: don't provide ioremap for CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 11 Nov 2019 11:31:05 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Palmer Dabbelt <palmer@...belt.com>,
        Christoph Hellwig <hch@....de>,
        "linux-ia64@...r.kernel.org" <linux-ia64@...r.kernel.org>,
        Linux-sh list <linux-sh@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Guo Ren <guoren@...nel.org>,
        sparclinux <sparclinux@...r.kernel.org>,
        linux-riscv@...ts.infradead.org,
        Vincent Chen <deanbo422@...il.com>,
        Linux-Arch <linux-arch@...r.kernel.org>,
        linux-s390 <linux-s390@...r.kernel.org>,
        "open list:QUALCOMM HEXAGON..." <linux-hexagon@...r.kernel.org>,
        "the arch/x86 maintainers" <x86@...nel.org>,
        arcml <linux-snps-arc@...ts.infradead.org>,
        linux-xtensa@...ux-xtensa.org,
        linux-m68k <linux-m68k@...ts.linux-m68k.org>,
        Openrisc <openrisc@...ts.librecores.org>,
        Greentime Hu <green.hu@...il.com>,
        MTD Maling List <linux-mtd@...ts.infradead.org>,
        Guan Xuetao <gxt@....edu.cn>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        Michal Simek <monstr@...str.eu>,
        Parisc List <linux-parisc@...r.kernel.org>,
        linux-mips@...r.kernel.org, alpha <linux-alpha@...r.kernel.org>,
        "moderated list:NIOS2 ARCHITECTURE" 
        <nios2-dev@...ts.rocketboards.org>
Subject: Re: [PATCH 11/21] asm-generic: don't provide ioremap for CONFIG_MMU

On Wed, Nov 6, 2019 at 7:16 PM Geert Uytterhoeven <geert@...ux-m68k.org> wrote:
>
> Hi Palmer,
>
> On Wed, Nov 6, 2019 at 7:11 PM Palmer Dabbelt <palmer@...belt.com> wrote:
> > It looks like the difference in prototype between the architectures is between
> >
> >     void __iomem *ioremap(resource_size_t, size_t)
> >     void __iomem *ioremap(phys_addr_t, size_t)
> >     void __iomem *ioremap(phys_addr_t, unsigned long)
> >     void __iomem *ioremap(unsigned long, unsigned long)
> >
> > shouldn't they all just be that first one?  In other words, wouldn't it be
> > better to always provide the generic ioremap prototype and unify the ports
> > instead?
>
> Agreed. But I'd go for the second one.

Right, phys_addr_t is the correct type here, resource_size_t is just a generic
type that is at least as long as any resource, and usually the same as
phys_addr_t, which is supposed to be used for physical addresses.

      Arnd