[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 11 Nov 2019 11:42:52 +0100
From: Uwe Kleine-König
<u.kleine-koenig@...gutronix.de>
To: "Vaittinen, Matti" <Matti.Vaittinen@...rohmeurope.com>
Cc: "thorsten.scherer@...elmann.de" <thorsten.scherer@...elmann.de>,
"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
"linus.walleij@...aro.org" <linus.walleij@...aro.org>,
"mazziesaccount@...il.com" <mazziesaccount@...il.com>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"bgolaszewski@...libre.com" <bgolaszewski@...libre.com>,
"kernel@...gutronix.de" <kernel@...gutronix.de>
Subject: Re: [PATCH 40/62] gpio: gpio-siox: Use new GPIO_LINE_DIRECTION
Hello Matti,
On Mon, Nov 11, 2019 at 07:43:50AM +0000, Vaittinen, Matti wrote:
> On Mon, 2019-11-11 at 08:27 +0100, Thorsten Scherer wrote:
> > Hello,
> >
> > On Tue, Nov 05, 2019 at 12:30:58PM +0200, Matti Vaittinen wrote:
> > > It's hard for occasional GPIO code reader/writer to know if values
> > > 0/1
> > > equal to IN or OUT. Use defined GPIO_LINE_DIRECTION_IN and
> > > GPIO_LINE_DIRECTION_OUT to help them out.
> > >
> > > Signed-off-by: Matti Vaittinen <matti.vaittinen@...rohmeurope.com>
> >
> > for SIOX gpio:
> >
> > Acked-by: Thorsten Scherer <t.scherer@...elmann.de>
> >
> > > Patches are compile-tested only. I have no HW to really test
> > > them. Thus
> > > I'd appreciate carefull review. This work is mainly about
> > > converting
> > > zeros and ones to the new defines but it wouldn't be first time I
> > > get it wrong in one of the patches
> > > :)
> >
> > Applied the patch(es) and tested them with SIOX device
> >
> > Tested-by: Thorsten Scherer <t.scherer@...elmann.de>
>
> Big thanks! It's _really_ nice that someone takes the time to do the
> testing! Highly appreciated! :]
without wanting to devalue Thorsten's testing, I think testing your
series can be trivially done without a runtime check as your patches
won't change the compiled result. So just compile once without the patch
and once with and compare the results. If they are bit-by-bit identical
everything is fine.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
Powered by blists - more mailing lists