linux-kernel - Re: [PATCH v3 02/11] mfd: wcd934x: add support to wcd9340/wcd9341 codec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 11 Nov 2019 13:36:10 +0000
From:   Lee Jones <lee.jones@...aro.org>
To:     Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
Cc:     robh@...nel.org, broonie@...nel.org, linus.walleij@...aro.org,
        vinod.koul@...aro.org, alsa-devel@...a-project.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        spapothi@...eaurora.org, bgoswami@...eaurora.org,
        linux-gpio@...r.kernel.org
Subject: Re: [PATCH v3 02/11] mfd: wcd934x: add support to wcd9340/wcd9341
 codec

> > > +static void wcd934x_slim_remove(struct slim_device *sdev)
> > > +{
> > > +	struct wcd934x_ddata *ddata = dev_get_drvdata(&sdev->dev);
> > > +
> > > +	regulator_bulk_disable(WCD934X_MAX_SUPPLY, ddata->supplies);
> > > +	mfd_remove_devices(&sdev->dev);
> > > +	kfree(ddata);
> > > +}
> > > +
> > > +static const struct slim_device_id wcd934x_slim_id[] = {
> > > +	{ SLIM_MANF_ID_QCOM, SLIM_PROD_CODE_WCD9340, 0x1, 0x0 },
> > 
> > What do the last parameters mean? Might be better to define them.
> 
> This is Instance ID and Device ID of SLIMBus enumeration address.

Great.

Please define them in the same was you did for the product code.

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog