[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 11 Nov 2019 14:14:42 +0000
From: John Garry <john.garry@...wei.com>
To: Anders Roxell <anders.roxell@...aro.org>, <catalin.marinas@....com>
CC: <will@...nel.org>, <linux-kernel@...r.kernel.org>,
<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] arm64: Kconfig: make CMDLINE_FORCE depend on CMDLINE
On 11/11/2019 08:59, Anders Roxell wrote:
> When building allmodconfig KCONFIG_ALLCONFIG=$(pwd)/arch/arm64/configs/defconfig
> CONFIG_CMDLINE_FORCE gets enabled. Which forces the user to pass the
> full cmdline to CONFIG_CMDLINE="...".
>
> Rework so that CONFIG_CMDLINE_FORCE gets set only if CONFIG_CMDLINE is
> set to something except an empty string.
>
> Suggested-by: John Garry <john.garry@...wei.com>
> Signed-off-by: Anders Roxell <anders.roxell@...aro.org>
> ---
This looks ok.
Were you also going to propose a patch to introduce a LITTLE ENDIAN
config option?
For me, this would mean that ACPI module is built for allmodconfig,
which is a good thing.
Thanks,
john
> arch/arm64/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> index 50df79d4aa3b..64764ca92fca 100644
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> @@ -1629,6 +1629,7 @@ config CMDLINE
>
> config CMDLINE_FORCE
> bool "Always use the default kernel command string"
> + depends on CMDLINE != ""
> help
> Always use the default kernel command string, even if the boot
> loader passes other arguments to the kernel.
>
Powered by blists - more mailing lists