[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 11 Nov 2019 06:44:13 -0800
From: Kevin Hilman <khilman@...libre.com>
To: Jianxin Pan <jianxin.pan@...ogic.com>,
linux-amlogic@...ts.infradead.org
Cc: Rob Herring <robh+dt@...nel.org>,
Neil Armstrong <narmstrong@...libre.com>,
Jerome Brunet <jbrunet@...libre.com>,
"Martin Blumenstingl" <martin.blumenstingl@...glemail.com>,
linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
Jian Hu <jian.hu@...ogic.com>,
Hanjie Lin <hanjie.lin@...ogic.com>,
Victor Wan <victor.wan@...ogic.com>,
Xingyu Chen <xingyu.chen@...ogic.com>
Subject: Re: [PATCH v4 3/4] soc: amlogic: Add support for Secure power domains controller
Hi Jianxin,
Jianxin Pan <jianxin.pan@...ogic.com> writes:
[...]
>>> + SEC_PD(RAMB, GENPD_FLAG_ALWAYS_ON),
>>> + SEC_PD(IR, 0),
>>> + SEC_PD(SPICC, 0),
>>> + SEC_PD(SPIFC, 0),
>>> + SEC_PD(USB, 0),
>>> + /* NIC is for NIC400, and should be always on */
>>
>> Why?
>>
> NIC domain is for ARM CoreLink NIC-400 Network Interconnect, and should be always on since bootloader.
OK, makes sense. I suggest a minor change to the comment to remind that
this is an interconnect:
/* NIC is for the Arm NIC-400 interconnect, and should be always on */
Thanks,
Kevin
Powered by blists - more mailing lists