linux-kernel - Re: [PATCH] VFIO/VMBUS: Add VFIO VMBUS driver support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 11 Nov 2019 08:47:12 -0800
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     "Greg KH" <gregkh@...uxfoundation.org>
Cc:     <lantianyu1986@...il.com>, <alex.williamson@...hat.com>,
        <cohuck@...hat.com>, "KY Srinivasan" <kys@...rosoft.com>,
        "Haiyang Zhang" <haiyangz@...rosoft.com>,
        "Stephen Hemminger" <sthemmin@...rosoft.com>, <sashal@...nel.org>,
        <mchehab+samsung@...nel.org>, <davem@...emloft.net>,
        <robh@...nel.org>, <Jonathan.Cameron@...wei.com>,
        <paulmck@...ux.ibm.com>, "Michael Kelley" <mikelley@...rosoft.com>,
        "Tianyu Lan" <Tianyu.Lan@...rosoft.com>,
        <linux-kernel@...r.kernel.org>, <kvm@...r.kernel.org>,
        <linux-hyperv@...r.kernel.org>, "vkuznets" <vkuznets@...hat.com>
Subject: Re: [PATCH] VFIO/VMBUS: Add VFIO VMBUS driver support

On Mon, 11 Nov 2019 01:49:20 -0800
"Greg KH" <gregkh@...uxfoundation.org> wrote:

> > +	ret = sysfs_create_bin_file(&channel->kobj,  
> &ring_buffer_bin_attr);
> > +	if (ret)
> > +		dev_notice(&dev->device,
> > +			   "sysfs create ring bin file failed; %d\n",  
> ret);
> > +  
> 
> Again, don't create sysfs files on your own, the bus code should be
> doing this for you automatically and in a way that is race-free.
> 
> thanks,
> 
> greg k-h

The sysfs file is only created if the VFIO/UIO driveris used.