linux-kernel - Re: [PATCH v2 3/3] staging: wfx: replace u32 by _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 11 Nov 2019 16:58:20 +0000
From:   Jerome Pouiller <Jerome.Pouiller@...abs.com>
To:     Jules Irenge <jbi.octave@...il.com>
CC:     "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 3/3] staging: wfx: replace u32 by __le32

On Monday 11 November 2019 14:30:55 CET Jules Irenge wrote:
[...]
> -       u32   count_rts_failures;
> -       u32   count_ack_failures;
> -       u32   count_rx_multicast_frames;
> -       u32   count_rx_frames_success;
> -       u32   count_rx_cmacicv_errors;
> -       u32   count_rx_cmac_replays;
> -       u32   count_rx_mgmt_ccmp_replays;
[...]
> +       __le32   count_rts_failures;
> +       __le32   count_rx_multicast_frames;
> +       __le32   count_rx_cmacicv_errors;
> +       __le32   count_rx_cmac_replays;
> +       __le32   count_rx_mgmt_ccmp_replays;
> +       __le32   count_rx_beacon;
> +       __le32   count_miss_beacon;
> +       __le32   count_ack_failures;
> +       __le32   count_rx_frames_success;
>         u32   count_rx_bipmic_errors;
> -       u32   count_rx_beacon;
> -       u32   count_miss_beacon;

Hello Jules,

Your patch reorders members of the structure. It will break API with the 
chip.

-- 
Jérôme Pouiller