linux-kernel - Re: [PATCH] irqchip/ti-sci-inta: Use ERR_CAST inlined function instead of ERR_PTR(PTR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 11 Nov 2019 09:05:39 +0530
From:   Lokesh Vutla <lokeshvutla@...com>
To:     Markus Elfring <Markus.Elfring@....de>,
        <linux-arm-kernel@...ts.infradead.org>,
        Jason Cooper <jason@...edaemon.net>,
        Marc Zyngier <maz@...nel.org>, Nishanth Menon <nm@...com>,
        Santosh Shilimkar <ssantosh@...nel.org>,
        Tero Kristo <t-kristo@...com>,
        Thomas Gleixner <tglx@...utronix.de>
CC:     LKML <linux-kernel@...r.kernel.org>,
        <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH] irqchip/ti-sci-inta: Use ERR_CAST inlined function
 instead of ERR_PTR(PTR_ERR(...))



On 05/11/19 5:00 PM, Markus Elfring wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Tue, 5 Nov 2019 12:19:39 +0100
> 
> A coccicheck run provided information like the following.
> 
> drivers/irqchip/irq-ti-sci-inta.c:250:9-16: WARNING: ERR_CAST can be used
> with vint_desc.
> 
> Generated by: scripts/coccinelle/api/err_cast.cocci
> 
> Thus adjust the exception handling in one if branch.
> 
> Fixes: 9f1463b86c13277d0bd88d5ee359577ef40f4da7 ("irqchip/ti-sci-inta: Add support for Interrupt Aggregator driver")

Fixes: 9f1463b86c13 ("irqchip/ti-sci-inta: Add support for Interrupt Aggregator
driver")

With this:

Reviewed-by: Lokesh Vutla <lokeshvutla@...com>

Thanks and regards,
Lokesh


> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
> ---
>  drivers/irqchip/irq-ti-sci-inta.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/irqchip/irq-ti-sci-inta.c b/drivers/irqchip/irq-ti-sci-inta.c
> index ef4d625d2d80..8f6e6b08eadf 100644
> --- a/drivers/irqchip/irq-ti-sci-inta.c
> +++ b/drivers/irqchip/irq-ti-sci-inta.c
> @@ -246,8 +246,8 @@ static struct ti_sci_inta_event_desc *ti_sci_inta_alloc_irq(struct irq_domain *d
>  	/* No free bits available. Allocate a new vint */
>  	vint_desc = ti_sci_inta_alloc_parent_irq(domain);
>  	if (IS_ERR(vint_desc)) {
> -		mutex_unlock(&inta->vint_mutex);
> -		return ERR_PTR(PTR_ERR(vint_desc));
> +		event_desc = ERR_CAST(vint_desc);
> +		goto unlock;
>  	}
> 
>  	free_bit = find_first_zero_bit(vint_desc->event_map,
> @@ -259,6 +259,7 @@ static struct ti_sci_inta_event_desc *ti_sci_inta_alloc_irq(struct irq_domain *d
>  	if (IS_ERR(event_desc))
>  		clear_bit(free_bit, vint_desc->event_map);
> 
> +unlock:
>  	mutex_unlock(&inta->vint_mutex);
>  	return event_desc;
>  }
> --
> 2.23.0
>