[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 11 Nov 2019 09:23:03 -0800
From: Kees Cook <keescook@...omium.org>
To: Geert Uytterhoeven <geert@...ux-m68k.org>
Cc: Borislav Petkov <bp@...en8.de>,
Rick Edgecombe <rick.p.edgecombe@...el.com>,
Dave Hansen <dave.hansen@...ux.intel.com>,
Andy Lutomirski <luto@...nel.org>,
Arnd Bergmann <arnd@...db.de>,
Michael Ellerman <mpe@...erman.id.au>,
Heiko Carstens <heiko.carstens@...ibm.com>,
Will Deacon <will@...nel.org>,
Linux-Arch <linux-arch@...r.kernel.org>,
Linux ARM <linux-arm-kernel@...ts.infradead.org>,
linuxppc-dev <linuxppc-dev@...ts.ozlabs.org>,
alpha <linux-alpha@...r.kernel.org>,
"linux-ia64@...r.kernel.org" <linux-ia64@...r.kernel.org>,
linux-s390 <linux-s390@...r.kernel.org>,
linux-c6x-dev@...ux-c6x.org,
Yoshinori Sato <ysato@...rs.sourceforge.jp>,
Michal Simek <monstr@...str.eu>,
Parisc List <linux-parisc@...r.kernel.org>,
linux-xtensa@...ux-xtensa.org,
the arch/x86 maintainers <x86@...nel.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 11/29] vmlinux.lds.h: Replace RODATA with RO_DATA
On Mon, Nov 11, 2019 at 05:58:06PM +0100, Geert Uytterhoeven wrote:
> Hi Kees,
>
> On Fri, Oct 11, 2019 at 2:07 AM Kees Cook <keescook@...omium.org> wrote:
> > There's no reason to keep the RODATA macro: replace the callers with
> > the expected RO_DATA macro.
> >
> > Signed-off-by: Kees Cook <keescook@...omium.org>
> > ---
> > arch/alpha/kernel/vmlinux.lds.S | 2 +-
> > arch/ia64/kernel/vmlinux.lds.S | 2 +-
> > arch/microblaze/kernel/vmlinux.lds.S | 2 +-
> > arch/mips/kernel/vmlinux.lds.S | 2 +-
> > arch/um/include/asm/common.lds.S | 2 +-
> > arch/xtensa/kernel/vmlinux.lds.S | 2 +-
> > include/asm-generic/vmlinux.lds.h | 4 +---
> > 7 files changed, 7 insertions(+), 9 deletions(-)
>
> Somehow you missed:
>
> arch/m68k/kernel/vmlinux-std.lds: RODATA
> arch/m68k/kernel/vmlinux-sun3.lds: RODATA
Argh. I've sent a patch; sorry and thanks for catching this. For my own
cross-build testing, which defconfig targets will hit these two linker
scripts?
-Kees
>
> Leading to build failures in next-20191111:
>
> /opt/cross/kisskb/gcc-4.6.3-nolibc/m68k-linux/bin/m68k-linux-ld:./arch/m68k/kernel/vmlinux.lds:29:
> syntax error
> make[1]: *** [/kisskb/src/Makefile:1075: vmlinux] Error 1
>
> Reported-by: noreply@...erman.id.au
> http://kisskb.ellerman.id.au/kisskb/buildresult/14022846/
>
> Gr{oetje,eeting}s,
>
> Geert
>
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
--
Kees Cook
Powered by blists - more mailing lists