linux-kernel - Re: [PATCH 7/9] staging: rtl8723bs: Fix incorrect type in argument warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c243860eeabf9406d166deb6204a69255c51867d.camel@perches.com>
Date:   Tue, 12 Nov 2019 09:11:42 -0800
From:   Joe Perches <joe@...ches.com>
To:     "Javier F. Arias" <jarias.linux@...il.com>,
        gregkh@...uxfoundation.org
Cc:     linux-kernel@...r.kernel.org, outreachy-kernel@...glegroups.com
Subject: Re: [PATCH 7/9] staging: rtl8723bs: Fix incorrect type in argument
 warnings

On Tue, 2019-11-12 at 11:55 -0500, Javier F. Arias wrote:
> Fix incorrect type in declarations to solve the 'incorrect
> type in argument 3' warnings in the rtw_get_ie function calls.
> Issue found by Sparse.
[]
> diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
[]
> @@ -83,7 +83,7 @@ static char *translate_scan(struct adapter *padapter,
>  {
>  	struct iw_event iwe;
>  	u16 cap;
> -	u32 ht_ielen = 0;
> +	sint ht_ielen = 0;

more likely the rtw_get_ie function should used u32
and not sint.

one day a sed of 's/\bsint\b/int/g' would be good too.