[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20191112171915.GA167243@google.com>
Date: Tue, 12 Nov 2019 11:19:15 -0600
From: Bjorn Helgaas <helgaas@...nel.org>
To: Michel Dänzer <michel@...nzer.net>
Cc: Alex Deucher <alexander.deucher@....com>,
Christian König <christian.koenig@....com>,
David Zhou <David1.Zhou@....com>,
David Airlie <airlied@...ux.ie>,
Daniel Vetter <daniel@...ll.ch>,
Frederick Lawler <fred@...dlawl.com>,
linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
dri-devel@...ts.freedesktop.org, amd-gfx@...ts.freedesktop.org
Subject: Re: [PATCH 1/2] drm: replace incorrect Compliance/Margin magic
numbers with PCI_EXP_LNKCTL2 definitions
On Tue, Nov 12, 2019 at 05:45:15PM +0100, Michel Dänzer wrote:
> On 2019-11-11 8:29 p.m., Bjorn Helgaas wrote:
> > From: Bjorn Helgaas <bhelgaas@...gle.com>
> >
> > Add definitions for these PCIe Link Control 2 register fields:
> >
> > Enter Compliance
> > Transmit Margin
> >
> > and use them in amdgpu and radeon.
> >
> > NOTE: This is a functional change because "7 << 9" was apparently a typo.
> > That mask included the high order bit of Transmit Margin, the Enter
> > Modified Compliance bit, and the Compliance SOS bit, but I think what
> > was intended was the 3-bit Transmit Margin field at bits 9:7.
>
> Can you split out the functional change into a separate patch 1? That
> could make things easier for anyone who bisects the functional change
> for whatever reason.
Great idea, thanks! Wish I'd thought of that.
While fixing that, I also noticed I missed one case in
amdgpu/si.c. I'll post a v3.
Powered by blists - more mailing lists