linux-kernel - Re: [PATCH 0/2] ALSA: pcm: Fix race condition in runtime access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5h1rud7yel.wl-tiwai@suse.de>
Date:   Tue, 12 Nov 2019 19:16:50 +0100
From:   Takashi Iwai <tiwai@...e.de>
To:     paulhsia <paulhsia@...omium.org>
Cc:     linux-kernel@...r.kernel.org, Mark Brown <broonie@...nel.org>,
        Takashi Iwai <tiwai@...e.com>, alsa-devel@...a-project.org
Subject: Re: [PATCH 0/2] ALSA: pcm: Fix race condition in runtime access

On Tue, 12 Nov 2019 18:17:13 +0100,
paulhsia wrote:
> 
> Since
> - snd_pcm_detach_substream sets runtime to null without stream lock and
> - snd_pcm_period_elapsed checks the nullity of the runtime outside of
>   stream lock.
> 
> This will trigger null memory access in snd_pcm_running() call in
> snd_pcm_period_elapsed.

Well, if a stream is detached, it means that the stream must have been
already closed; i.e. it's already a clear bug in the driver that
snd_pcm_period_elapsed() is called against such a stream.

Or am I missing other possible case?


thanks,

Takashi

> 
> paulhsia (2):
>   ALSA: pcm: Fix stream lock usage in snd_pcm_period_elapsed()
>   ALSA: pcm: Use stream lock in snd_pcm_detach_substream()
> 
>  sound/core/pcm.c     | 8 +++++++-
>  sound/core/pcm_lib.c | 8 ++++++--
>  2 files changed, 13 insertions(+), 3 deletions(-)
> 
> -- 
> 2.24.0.rc1.363.gb1bccd3e3d-goog
>