linux-kernel - Re: [PATCH -next] net: ethernet: ti: Add dependency for TI_DAVINCI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191112.105124.1905938227505046893.davem@davemloft.net>
Date:   Tue, 12 Nov 2019 10:51:24 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     maowenan@...wei.com
Cc:     andrew@...n.ch, grygorii.strashko@...com, tony@...mide.com,
        brouer@...hat.com, jakub.kicinski@...ronome.com,
        ivan.khoronzhuk@...aro.org, tglx@...utronix.de,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH -next] net: ethernet: ti: Add dependency for
 TI_DAVINCI_EMAC

From: Mao Wenan <maowenan@...wei.com>
Date: Tue, 12 Nov 2019 14:33:58 +0800

> If TI_DAVINCI_EMAC=y and GENERIC_ALLOCATOR is not set,
> below erros can be seen:
> drivers/net/ethernet/ti/davinci_cpdma.o: In function `cpdma_desc_pool_destroy.isra.14':
> davinci_cpdma.c:(.text+0x359): undefined reference to `gen_pool_size'
> davinci_cpdma.c:(.text+0x365): undefined reference to `gen_pool_avail'
> davinci_cpdma.c:(.text+0x373): undefined reference to `gen_pool_avail'
> davinci_cpdma.c:(.text+0x37f): undefined reference to `gen_pool_size'
> drivers/net/ethernet/ti/davinci_cpdma.o: In function `__cpdma_chan_free':
> davinci_cpdma.c:(.text+0x4a2): undefined reference to `gen_pool_free_owner'
> drivers/net/ethernet/ti/davinci_cpdma.o: In function `cpdma_chan_submit_si':
> davinci_cpdma.c:(.text+0x66c): undefined reference to `gen_pool_alloc_algo_owner'
> davinci_cpdma.c:(.text+0x805): undefined reference to `gen_pool_free_owner'
> drivers/net/ethernet/ti/davinci_cpdma.o: In function `cpdma_ctlr_create':
> davinci_cpdma.c:(.text+0xabd): undefined reference to `devm_gen_pool_create'
> davinci_cpdma.c:(.text+0xb79): undefined reference to `gen_pool_add_owner'
> drivers/net/ethernet/ti/davinci_cpdma.o: In function `cpdma_check_free_tx_desc':
> davinci_cpdma.c:(.text+0x16c6): undefined reference to `gen_pool_avail'
> 
> This patch mades TI_DAVINCI_EMAC select GENERIC_ALLOCATOR.
> 
> Fixes: 99f629718272 ("net: ethernet: ti: cpsw: drop TI_DAVINCI_CPDMA config option")
> Signed-off-by: Mao Wenan <maowenan@...wei.com>

Applied.