linux-kernel - Re: [PATCH v1 2/5] char: tpm: Add check_data handle to tpm_tis_phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 12 Nov 2019 22:22:47 +0200
From:   Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
To:     amirmizi6@...il.com
Cc:     Eyal.Cohen@...oton.com, oshrialkoby85@...il.com,
        alexander.steffen@...ineon.com, robh+dt@...nel.org,
        mark.rutland@....com, peterhuewe@....de, jgg@...pe.ca,
        arnd@...db.de, gregkh@...uxfoundation.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-integrity@...r.kernel.org, oshri.alkoby@...oton.com,
        tmaimon77@...il.com, gcwilson@...ibm.com, kgoldman@...ibm.com,
        ayna@...ux.vnet.ibm.com, Dan.Morav@...oton.com,
        oren.tanami@...oton.com, shmulik.hagar@...oton.com,
        amir.mizinski@...oton.com
Subject: Re: [PATCH v1 2/5] char: tpm: Add check_data handle to
 tpm_tis_phy_ops in order to check data integrity

On Sun, Nov 10, 2019 at 06:21:34PM +0200, amirmizi6@...il.com wrote:
> From: Amir Mizinski <amirmizi6@...il.com>
> 
> The current principles:
> - When sending command:
> 1. Host writes TPM_STS.commandReady
> 2. Host writes command
> 3. Host checks TPM received data correctly
> 4. if not go to step 1

You are probably talking about steps, right?

Please check the grammar and punctation e.g. "The current steps are
roughly done when sending a command".

> - When receiving data:
> 1. Host check TPM_STS.dataAvail is set
> 2. Host get data
> 3. Host check received data are correct.
> 4. if not Host write TPM_STS.responseRetry and go to step 1.
> 
> this commit is based on previous work by Christophe Richard

Sentences in English start with a capital letter and end with a full
stop.

This is completely lacking the description what the commit does.

/Jarkko