linux-kernel - Re: [PATCH v3 3/4] Bluetooth: hci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <201911130619.VJNnci8E%lkp@intel.com>
Date:   Wed, 13 Nov 2019 06:49:44 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Abhishek Pandit-Subedi <abhishekpandit@...omium.org>
Cc:     kbuild-all@...ts.01.org, Marcel Holtmann <marcel@...tmann.org>,
        Johan Hedberg <johan.hedberg@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        linux-bluetooth@...r.kernel.org, dianders@...omium.org,
        Abhishek Pandit-Subedi <abhishekpandit@...omium.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 3/4] Bluetooth: hci_bcm: Support pcm params in dts

Hi Abhishek,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on bluetooth-next/master]
[cannot apply to v5.4-rc7 next-20191112]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Abhishek-Pandit-Subedi/Bluetooth-hci_bcm-Additional-changes-for-BCM4354-support/20191113-053047
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git master
config: sparc64-allmodconfig (attached as .config)
compiler: sparc64-linux-gcc (GCC) 7.4.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.4.0 make.cross ARCH=sparc64 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   drivers/bluetooth/hci_bcm.c: In function 'bcm_setup':
>> drivers/bluetooth/hci_bcm.c:606:9: error: implicit declaration of function 'btbcm_set_pcm_params'; did you mean 'btbcm_set_pcm_int_params'? [-Werror=implicit-function-declaration]
      err = btbcm_set_pcm_params(hu->hdev, &bcm->dev->pcm_params,
            ^~~~~~~~~~~~~~~~~~~~
            btbcm_set_pcm_int_params
   cc1: some warnings being treated as errors

vim +606 drivers/bluetooth/hci_bcm.c

   543	
   544	static int bcm_setup(struct hci_uart *hu)
   545	{
   546		struct bcm_data *bcm = hu->priv;
   547		char fw_name[64];
   548		const struct firmware *fw;
   549		unsigned int speed;
   550		int err;
   551	
   552		bt_dev_dbg(hu->hdev, "hu %p", hu);
   553	
   554		hu->hdev->set_diag = bcm_set_diag;
   555		hu->hdev->set_bdaddr = btbcm_set_bdaddr;
   556	
   557		err = btbcm_initialize(hu->hdev, fw_name, sizeof(fw_name), false);
   558		if (err)
   559			return err;
   560	
   561		err = request_firmware(&fw, fw_name, &hu->hdev->dev);
   562		if (err < 0) {
   563			bt_dev_info(hu->hdev, "BCM: Patch %s not found", fw_name);
   564			return 0;
   565		}
   566	
   567		err = btbcm_patchram(hu->hdev, fw);
   568		if (err) {
   569			bt_dev_info(hu->hdev, "BCM: Patch failed (%d)", err);
   570			goto finalize;
   571		}
   572	
   573		/* If we disallow early set baudrate, we can re-enable it now that
   574		 * patchram is done
   575		 */
   576		if (bcm->dev && bcm->dev->disallow_set_baudrate)
   577			bcm->dev->disallow_set_baudrate = false;
   578	
   579		/* Init speed if any */
   580		if (hu->init_speed)
   581			speed = hu->init_speed;
   582		else if (hu->proto->init_speed)
   583			speed = hu->proto->init_speed;
   584		else
   585			speed = 0;
   586	
   587		if (speed)
   588			host_set_baudrate(hu, speed);
   589	
   590		/* Operational speed if any */
   591		if (hu->oper_speed)
   592			speed = hu->oper_speed;
   593		else if (hu->proto->oper_speed)
   594			speed = hu->proto->oper_speed;
   595		else
   596			speed = 0;
   597	
   598		if (speed) {
   599			err = bcm_set_baudrate(hu, speed);
   600			if (!err)
   601				host_set_baudrate(hu, speed);
   602		}
   603	
   604		/* PCM parameters if any*/
   605		if (bcm->dev && bcm->dev->has_pcm_params) {
 > 606			err = btbcm_set_pcm_params(hu->hdev, &bcm->dev->pcm_params,
   607						   NULL);
   608	
   609			if (err) {
   610				bt_dev_info(hu->hdev, "BCM: Set pcm params failed (%d)",
   611					    err);
   612			}
   613		}
   614	
   615	finalize:
   616		release_firmware(fw);
   617	
   618		err = btbcm_finalize(hu->hdev);
   619		if (err)
   620			return err;
   621	
   622		if (!bcm_request_irq(bcm))
   623			err = bcm_setup_sleep(hu);
   624	
   625		return err;
   626	}
   627	

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (59102 bytes)