linux-kernel - Re: [PATCH] rtl8xxxu: Remove set but not used variable 'rsr'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAB4CAwfCNgd6nr9yrPtPd33P075CURKw+e3ZOUN0iKecvJfR2Q@mail.gmail.com>
Date:   Tue, 12 Nov 2019 10:28:52 +0800
From:   Chris Chiu <chiu@...lessm.com>
To:     Zheng Yongjun <zhengyongjun3@...wei.com>
Cc:     Jes Sorensen <Jes.Sorensen@...il.com>,
        Kalle Valo <kvalo@...eaurora.org>,
        David Miller <davem@...emloft.net>,
        linux-wireless <linux-wireless@...r.kernel.org>,
        Linux Kernel <linux-kernel@...r.kernel.org>,
        Hulk Robot <hulkci@...wei.com>
Subject: Re: [PATCH] rtl8xxxu: Remove set but not used variable 'rsr'

On Sun, Nov 10, 2019 at 6:51 PM Zheng Yongjun <zhengyongjun3@...wei.com> wrote:
>
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c: In function rtl8xxxu_gen2_config_channel:
> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:1266:13: warning: variable rsr set but not used [-Wunused-but-set-variable]
>
> rsr is never used, so remove it.
>
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Zheng Yongjun <zhengyongjun3@...wei.com>
Reviewed-by: Chris Chiu <chiu@...lessm.com>

Since the rtl8xxxu_gen2_config_channel is only invoked for 8723BU. I
verified the hal/rtl8723b_phycfg.c of RTL8723BU vendor driver. The RSR
register is also left intact. This commit looks good to me.

> ---
>  drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
> index c6c41fb962ff..2c1ca4bc4e56 100644
> --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
> +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
> @@ -1255,7 +1255,7 @@ void rtl8xxxu_gen1_config_channel(struct ieee80211_hw *hw)
>  void rtl8xxxu_gen2_config_channel(struct ieee80211_hw *hw)
>  {
>         struct rtl8xxxu_priv *priv = hw->priv;
> -       u32 val32, rsr;
> +       u32 val32;
>         u8 val8, subchannel;
>         u16 rf_mode_bw;
>         bool ht = true;
> @@ -1264,7 +1264,6 @@ void rtl8xxxu_gen2_config_channel(struct ieee80211_hw *hw)
>
>         rf_mode_bw = rtl8xxxu_read16(priv, REG_WMAC_TRXPTCL_CTL);
>         rf_mode_bw &= ~WMAC_TRXPTCL_CTL_BW_MASK;
> -       rsr = rtl8xxxu_read32(priv, REG_RESPONSE_RATE_SET);
>         channel = hw->conf.chandef.chan->hw_value;
>
>  /* Hack */
> --
> 2.23.0
>