linux-kernel - Re: [PATCH 2/4] scsi: hisi_sas: Return directly if init hardware failed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fc7c92a8-fd18-ae61-2ec5-0ad79f4e4fac@huawei.com>
Date:   Tue, 12 Nov 2019 09:36:13 +0000
From:   John Garry <john.garry@...wei.com>
To:     <jejb@...ux.vnet.ibm.com>, <martin.petersen@...cle.com>
CC:     <linux-scsi@...r.kernel.org>, <linuxarm@...wei.com>,
        <linux-kernel@...r.kernel.org>,
        Xiang Chen <chenxiang66@...ilicon.com>
Subject: Re: [PATCH 2/4] scsi: hisi_sas: Return directly if init hardware
 failed

On 12/11/2019 09:30, John Garry wrote:
> From: Xiang Chen <chenxiang66@...ilicon.com>
> 
> Need to return directly if init hardware failed.
> 
> Fixes: 73a4925d154c ("scsi: hisi_sas: Update all the registers after suspend and resume")
> Signed-off-by: Xiang Chen <chenxiang66@...ilicon.com>

I missed my tag here:
Signed-off-by: John Garry <john.garry@...wei.com>

> ---
>   drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c b/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c
> index 2ae7070db41a..b7836406debe 100644
> --- a/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c
> +++ b/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c
> @@ -3432,6 +3432,7 @@ static int hisi_sas_v3_resume(struct pci_dev *pdev)
>   	if (rc) {
>   		scsi_remove_host(shost);
>   		pci_disable_device(pdev);
> +		return rc;
>   	}
>   	hisi_hba->hw->phys_init(hisi_hba);
>   	sas_resume_ha(sha);
>