linux-kernel - Re: [PATCH 3/3] arm64: dts: rk3399: Add init voltage for vdd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <17e14b30-02ee-2379-8891-088677924479@rock-chips.com>
Date:   Tue, 12 Nov 2019 18:02:37 +0800
From:   Kever Yang <kever.yang@...k-chips.com>
To:     Markus Reichl <m.reichl@...etechno.de>, Soeren Moch <smoch@....de>,
        heiko@...ech.de
Cc:     Mark Rutland <mark.rutland@....com>,
        Andrius Štikonas <andrius@...konas.eu>,
        linux-kernel@...r.kernel.org, Alexis Ballier <aballier@...too.org>,
        linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
        Katsuhiro Suzuki <katsuhiro@...suster.net>,
        Hugh Cole-Baker <sigmaris@...il.com>,
        Elaine Zhang <zhangqing@...k-chips.com>,
        Andy Yan <andyshrk@...il.com>,
        Robin Murphy <robin.murphy@....com>,
        Vicente Bergas <vicencb@...il.com>,
        Oskari Lemmela <oskari@...mela.net>,
        linux-rockchip@...ts.infradead.org,
        Rob Herring <robh+dt@...nel.org>,
        Pragnesh Patel <Pragnesh_Patel@...tor.com>,
        Peter Robinson <pbrobinson@...il.com>,
        Nick Xie <nick@...das.com>,
        Ezequiel Garcia <ezequiel@...labora.com>,
        Vivek Unune <npcomplete13@...il.com>,
        Akash Gajjar <akash@...nedev.com>
Subject: Re: [PATCH 3/3] arm64: dts: rk3399: Add init voltage for vdd_log

Markus,


On 2019/11/12 下午4:16, Markus Reichl wrote:
> Hi Kever,
>
> have a rk3399-roc-pc running mainline U-Boot and kernel and vdd_log is
> showing 1118 mV.

The rk3399-roc-pc have the same vdd_log circuit in schematic, so it 
should like the patch 1/3 of

this patch set.

I don't understand who is setting this value, maybe the default value 
without pwm regulator enabled?

> Is this a danger for the board?
> How to fix it?

The best way is to set correct min/max microvolt of the 
regulator(measure with PWM output low and high),

(note that if  no driver touch the regulator, the PWM is default input, 
not output;)

and set a init-microvolt for U-Boot driver, and I think no kernel driver 
touch this regulator now.


Thanks,

- Kever

> Btw. vin-supply for this pwm-regulator is ignored and I could not find it
> in bindings doc.
>
> Gruß,